fix: ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om the cloud Pub/Sub Message fixes: #311
product-auto-label
bot
added
the
api: pubsublite
…om the cloud Pub/Sub Message fixes: #311
pradn
approved these changes
Mar 7, 2022
pradn
left a comment
pradn
left a comment
There was a problem hiding this comment.
Good change to not rely on the Message ctor. Just one comment for thought. Thanks!
dpcollins-google
added
the
automerge
hannahrogers-google
approved these changes
Mar 7, 2022
…om the cloud Pub/Sub Message fixes: #311
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
🤖 I have created a release *beep* *boop* --- ### [1.4.1](v1.4.0...v1.4.1) (2022-03-07) ### Bug Fixes * ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message ([#312](#312)) ([19da693](19da693)), closes [#311](#311) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #311