-
Notifications
You must be signed in to change notification settings - Fork 12
Labels
api: pubsubliteIssues related to the googleapis/python-pubsublite API.Issues related to the googleapis/python-pubsublite API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
python-pubsublite/tests/unit/pubsublite/cloudpubsub/internal/single_partition_subscriber_test.py
Lines 250 to 252 in 1d223f4
| async def test_nack_calls_ack( | |
| subscriber: SinglePartitionSingleSubscriber, | |
| underlying, |
Unit test test_nack_calls_ack() started timing out in main after google-cloud-pubsub==2.10.0 was released. See build log here and the checks in PR #310.
Test test_nack_calls_ack() no longer hangs when I change the google-cloud-pubsub dependency in setup.py from "google-cloud-pubsub >= 2.1.0, <3.0.0dev", to "google-cloud-pubsub >= 2.1.0, <3.0.0dev, !=2.10.0",
Metadata
Metadata
Assignees
Labels
api: pubsubliteIssues related to the googleapis/python-pubsublite API.Issues related to the googleapis/python-pubsublite API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.