fix: correct TypeError and comparison issues discovered in DateArray compliance tests by tswast · Pull Request #79 · googleapis/python-db-dtypes-pandas

tswast · 2022-03-09T19:33:41Z

As #64 was getting long, this pulls out some of the smaller changes for easier review.

The compliance tests are modeled after https://github.com/pandas-dev/pandas/blob/main/pandas/tests/extension/decimal/test_decimal.py, including the order of classes in the test suite. "Reduce" classes are skipped due to #78

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Towards #28 🦕

TODO:

Compliance tests should probably only run against the latest pandas. Probably not worth investigating the 3.8 failures.

test: add a test session with prerelease versions of dependencies

This makes them consistent with other date/time dtypes, as well as internally consistent with the advertised `dtype.na_value`. BREAKING-CHANGE: dbdate and dbtime dtypes return NaT instead of None for missing values Release-As: 0.4.0

…ed2DTests

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…types-pandas into issue28-TypeError

parthea

Added minor observations, otherwise LGTM

parthea · 2022-03-10T01:00:16Z

.github/workflows/unittest.yml

        name: coverage-artifacts
        path: .coverage-${{ matrix.python }}

+  compliance:


alternatively, you could pull this into a separate file called unittest-compliance.yml and remove the customizations in owlbot.py for .github/workflows/unittest.yml. Owlbot shouldn't overwrite the changes because unittest-compliance.yml doesn't exist in templates.

I'll give that a try! I was thinking mostly about having this count towards coverage, but I see that specifically calls out tests/unit, so this isn't as important.

parthea · 2022-03-10T01:04:32Z

tests/compliance/date/test_date_compliance.py

+
+
+class TestGetitem(base.BaseGetitemTests):
+    def test_take_na_value_other_date(self):


It would be helpful to have an additional comment in the test to clarify the expected behaviour

👍 Would have been nice if pandas had a bit more of an explanatory comment, but I'll try and deduce why this test was added in pandas-dev/pandas#20814. Perhaps it's not even necessary in general?

Removed, as most other extension dtype tests don't have it.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…hon-db-dtypes-pandas into issue28-TypeError

🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.1...v0.4.0) (2022-03-24) ### ⚠ BREAKING CHANGES * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * dbdate and dbtime dtypes return NaT instead of None for missing values ### Features * dbdate and dbtime support numpy.datetime64 values in array constructor ([1db1357](1db1357)) ### Bug Fixes * address failing 2D array compliance tests in DateArray ([#64](#64)) ([b771e05](b771e05)) * address failing tests with pandas 1.5.0 ([#82](#82)) ([38ac28d](38ac28d)) * allow comparison with scalar values ([#88](#88)) ([7495698](7495698)) * avoid TypeError when using sorted search ([#84](#84)) ([42bc2d9](42bc2d9)) * correct TypeError and comparison issues discovered in DateArray compliance tests ([#79](#79)) ([1e979cf](1e979cf)) * dbdate and dbtime support set item with null values ([#85](#85)) ([1db1357](1db1357)) * use `pandas.NaT` for missing values in dbdate and dbtime dtypes ([#67](#67)) ([f903c2c](f903c2c)) * use public pandas APIs where possible ([#60](#60)) ([e9d41d1](e9d41d1)) ### Tests * add dbtime compliance tests ([#90](#90)) ([f14fb2b](f14fb2b)) * add final dbdate compliance tests and sort ([#89](#89)) ([efe7e6d](efe7e6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.4.0](googleapis/python-db-dtypes-pandas@v0.3.1...v0.4.0) (2022-03-24) ### ⚠ BREAKING CHANGES * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * dbdate and dbtime dtypes return NaT instead of None for missing values ### Features * dbdate and dbtime support numpy.datetime64 values in array constructor ([1db1357](googleapis/python-db-dtypes-pandas@1db1357)) ### Bug Fixes * address failing 2D array compliance tests in DateArray ([#64](googleapis/python-db-dtypes-pandas#64)) ([b771e05](googleapis/python-db-dtypes-pandas@b771e05)) * address failing tests with pandas 1.5.0 ([#82](googleapis/python-db-dtypes-pandas#82)) ([38ac28d](googleapis/python-db-dtypes-pandas@38ac28d)) * allow comparison with scalar values ([#88](googleapis/python-db-dtypes-pandas#88)) ([7495698](googleapis/python-db-dtypes-pandas@7495698)) * avoid TypeError when using sorted search ([#84](googleapis/python-db-dtypes-pandas#84)) ([42bc2d9](googleapis/python-db-dtypes-pandas@42bc2d9)) * correct TypeError and comparison issues discovered in DateArray compliance tests ([#79](googleapis/python-db-dtypes-pandas#79)) ([1e979cf](googleapis/python-db-dtypes-pandas@1e979cf)) * dbdate and dbtime support set item with null values ([#85](googleapis/python-db-dtypes-pandas#85)) ([1db1357](googleapis/python-db-dtypes-pandas@1db1357)) * use `pandas.NaT` for missing values in dbdate and dbtime dtypes ([#67](googleapis/python-db-dtypes-pandas#67)) ([f903c2c](googleapis/python-db-dtypes-pandas@f903c2c)) * use public pandas APIs where possible ([#60](googleapis/python-db-dtypes-pandas#60)) ([e9d41d1](googleapis/python-db-dtypes-pandas@e9d41d1)) ### Tests * add dbtime compliance tests ([#90](googleapis/python-db-dtypes-pandas#90)) ([f14fb2b](googleapis/python-db-dtypes-pandas@f14fb2b)) * add final dbdate compliance tests and sort ([#89](googleapis/python-db-dtypes-pandas#89)) ([efe7e6d](googleapis/python-db-dtypes-pandas@efe7e6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

tswast added 11 commits January 27, 2022 11:10

fix: address failing compliance tests in DateArray and TimeArray

b48ee6d

test: add a test session with prerelease versions of dependencies

fix min/max/median for 2D arrays

90e1573

fixes except for null contains

47100f5

actually use NaT as 'advertised'

cece518

Merge branch 'issue28-NaT' into issue28-NDArrayBacked2DTests

cd84754

Merge remote-tracking branch 'upstream/main' into issue28-NDArrayBack…

f807c6f

…ed2DTests

more progress towards compliance

cc713a8

address errors in TestMethods

164101a

fix: correct dtype and interface compliance errors in DateArray

fb13f0c

Merge remote-tracking branch 'upstream/main' into issue28-TypeError

111a19c

tswast requested a review from a team as a code owner March 9, 2022 19:33

tswast requested review from a team and steffnay March 9, 2022 19:33

product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Mar 9, 2022

tswast and others added 6 commits March 9, 2022 16:43

add compliance tests to github actions

58d3941

🦉 Updates from OwlBot post-processor

7b58a6d

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

split coverage

8811422

Merge branch 'issue28-TypeError' of github.com:googleapis/python-db-d…

c2b25c8

…types-pandas into issue28-TypeError

add nox session back

9fafe8e

fix unit session

58da8e0

parthea approved these changes Mar 10, 2022

View reviewed changes

tswast added 3 commits March 10, 2022 12:10

move compliance tests and remove unnecessary test

d654527

no need for coverage upload

69560d2

fix coverage

ce8d12a

tswast requested a review from parthea March 10, 2022 19:13

tswast and others added 3 commits March 10, 2022 13:13

restore coverage

8c5804f

🦉 Updates from OwlBot post-processor

c2b0db6

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'issue28-TypeError' of https://github.com/googleapis/pyt…

ca693cd

…hon-db-dtypes-pandas into issue28-TypeError

tswast merged commit 1e979cf into main Mar 10, 2022

tswast deleted the issue28-TypeError branch March 10, 2022 19:41

release-please bot mentioned this pull request Mar 10, 2022

chore(main): release 0.4.0 #62

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: correct TypeError and comparison issues discovered in DateArray compliance tests#79

fix: correct TypeError and comparison issues discovered in DateArray compliance tests#79
tswast merged 23 commits intomainfrom
issue28-TypeError

tswast commented Mar 9, 2022 •

edited

Loading

Uh oh!

parthea left a comment

Uh oh!

parthea Mar 10, 2022

Uh oh!

tswast Mar 10, 2022

Uh oh!

parthea Mar 10, 2022

Uh oh!

tswast Mar 10, 2022

Uh oh!

tswast Mar 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		class TestGetitem(base.BaseGetitemTests):
		def test_take_na_value_other_date(self):

Conversation

tswast commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parthea left a comment

Choose a reason for hiding this comment

Uh oh!

parthea Mar 10, 2022

Choose a reason for hiding this comment

Uh oh!

tswast Mar 10, 2022

Choose a reason for hiding this comment

Uh oh!

parthea Mar 10, 2022

Choose a reason for hiding this comment

Uh oh!

tswast Mar 10, 2022

Choose a reason for hiding this comment

Uh oh!

tswast Mar 10, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tswast commented Mar 9, 2022 •

edited

Loading