Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: require six>=1.12.0 and google-api-core>=1.21.0 #46

Merged
merged 1 commit into from
Nov 18, 2020
Merged

deps: require six>=1.12.0 and google-api-core>=1.21.0 #46

merged 1 commit into from
Nov 18, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 18, 2020 •
edited
Loading

  • six>=1.12.0 is to support legacy App Engine standard runtimes
  • google-api-core>=1.21.0 is needed for DuplicateCredentialArgs
    exception

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #45 🦕

@tswast
deps: require six>=1.12.0 and google-api-core>=1.21.0
42aa73d 
* `six>=1.12.0` is to support legacy App Engine standard runtimes
* `google-api-core>=1.21.0` is needed for `DuplicateCredentialArgs`
  exception
@tswast tswast requested a review from a team as a code owner November 18, 2020 15:42
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2020
@tswast
Copy link
Contributor Author

tswast commented Nov 18, 2020

constraints-PY_VER.txt pattern is following the pattern I used here: googleapis/python-bigquery#263 and hope to add to the generated noxfiles here: googleapis/synthtool#839

busunkim96
busunkim96 approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tswast!

@busunkim96 busunkim96 merged commit a97b9ca into googleapis:master Nov 18, 2020
@tswast tswast deleted the issue45-collections_abc branch November 18, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import six.moves.collections_abc
2 participants
@tswast @busunkim96