Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: noxfile support for constraints #839

Closed
tswast opened this issue Nov 4, 2020 · 1 comment · Fixed by #869
Closed

Python: noxfile support for constraints #839

tswast opened this issue Nov 4, 2020 · 1 comment · Fixed by #869
Assignees
@busunkim96
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Nov 4, 2020

In the BigQuery libraries, we have more dependencies in the library than some other libraries (mostly optional, via "extras"). I'd like to be able to have some tests the depend on specific versions so that we can ensure the version ranges in setup.py are correct.

In google-cloud-bigquery we do this by adding testing/constraints-X.Y.txt files, where X.Y==session.python in nox.

It'd be nice if the template had support for this feature so that we could use constraints.txt files in the other BigQuery libraries without too much manual regex.
@tswast tswast mentioned this issue Nov 4, 2020
Closed
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 5, 2020
@busunkim96 busunkim96 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Nov 5, 2020
@tswast tswast mentioned this issue Nov 18, 2020
Merged
4 tasks
@SurferJeffAtGoogle SurferJeffAtGoogle added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Dec 4, 2020
@busunkim96 busunkim96 assigned busunkim96 and unassigned parthea Dec 4, 2020
@busunkim96
Copy link
Contributor

In progress in #869

@busunkim96 busunkim96 linked a pull request Dec 4, 2020 that will close this issue
test(python): use constraints files to check dependency lower bounds #869
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(python): use constraints files to check dependency lower bounds googleapis/synthtool
5 participants
@tswast @parthea @busunkim96 @SurferJeffAtGoogle @yoshi-automation