This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
chore: use http in LICENSE to match Apache version exactly #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters.
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Thu Jan 7 11:58:32 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: f15b57ccfd71106c2299e9b89835fe6e55015662 Source-Link: googleapis/synthtool@f15b57c
Co-authored-by: Tim Swast <swast@google.com> Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Thu Jan 7 13:05:12 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: 41a4e56982620d3edcf110d76f4fcdfdec471ac8 Source-Link: googleapis/synthtool@41a4e56
product-auto-label
bot
added
the
api: bigqueryreservation
Issues related to the googleapis/python-bigquery-reservation API.
label
Jan 8, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jan 8, 2021
tswast
changed the title
[CHANGE ME] Re-generated to pick up changes from synthtool.
chore: use http in LICENSE to match Apache version exactly
Jan 8, 2021
tswast
approved these changes
Jan 8, 2021
tswast
reviewed
Jan 8, 2021
samples/snippets/noxfile.py
Outdated
@@ -38,25 +38,28 @@ | |||
|
|||
TEST_CONFIG = { | |||
# You can opt out from the test for specific Python versions. | |||
"ignored_versions": ["2.7"], | |||
'ignored_versions': ["2.7"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crwilcox I'm a bit curious as to why the "blacken" gets reverted. We run blacken
as the last step here: https://github.com/googleapis/python-bigquery-reservation/blob/master/synth.py#L66
But maybe we need to loop through the samples directories and run those blacken sessions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting for now. Can discuss in #66 which contains only this change.
tswast
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Jan 8, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Jan 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: bigqueryreservation
Issues related to the googleapis/python-bigquery-reservation API.
cla: yes
This human has signed the Contributor License Agreement.
context: partial
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/008ce5bf-87d6-4df6-a516-9e6d6ecebea4/targets
Source-Link: googleapis/synthtool@41a4e56
Source-Link: googleapis/synthtool@f15b57c