This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
chore: unblacken snippets noxfile #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
yoshi-automation
force-pushed
the
autosynth-self
branch
from
c500ed3 to
a0080c4
Compare
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigqueryreservation
tswast
changed the title
|
As I said here: https://github.com/googleapis/python-bigquery-reservation/pull/68/files#r554008409 I'm a bit curious as to why the "blacken" gets reverted. We run blacken as the last step here: https://github.com/googleapis/python-bigquery-reservation/blob/master/synth.py#L66 But maybe we need to loop through the samples directories and run those blacken sessions? |
This was referenced Jan 8, 2021
tswast
added
the
do not merge
|
Oof, honestly, I'm not sure what's going on under the hood here. My grasp of synthtool magic is minimal. I'm not sure if it means we need to blacken the noxfile template in the synthtool repo itself, or if it's something special here. @busunkim96 might have an opinion here |
|
@leahecole #71 should fix it in the future |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 3, 2021
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-reservation/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes googleapis/synthtool#899 🦕 Closes #66
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Sep 22, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-reservation/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes googleapis/synthtool#899 🦕 Closes googleapis/python-bigquery-reservation#66
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/008ce5bf-87d6-4df6-a516-9e6d6ecebea4/targets