Skip to content

fix: added option to set fps in video metadata according to the documentation #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: added option to set fps in video metadata according to the documentation #6074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da93b0
added option to set fps in video metadata according to the docs
philipshurpik Oct 31, 2025
aa385fe
using fps in video metadata in tests
philipshurpik Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions google/cloud/aiplatform_v1/types/content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,8 @@ class VideoMetadata(proto.Message):
Optional. The start offset of the video.
end_offset (google.protobuf.duration_pb2.Duration):
Optional. The end offset of the video.
fps (float):
Optional. The frame rate of the video sent to the model. If not specified, the default value is 1.0.
"""

start_offset: duration_pb2.Duration = proto.Field(
Expand All @@ -339,6 +341,10 @@ class VideoMetadata(proto.Message):
number=2,
message=duration_pb2.Duration,
)
fps: float = proto.Field(
proto.DOUBLE,
number=3,
)


class ImageConfig(proto.Message):
Expand Down
6 changes: 6 additions & 0 deletions google/cloud/aiplatform_v1beta1/types/content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,8 @@ class VideoMetadata(proto.Message):
Optional. The start offset of the video.
end_offset (google.protobuf.duration_pb2.Duration):
Optional. The end offset of the video.
fps (float):
Optional. The frame rate of the video sent to the model. If not specified, the default value is 1.0.
"""

start_offset: duration_pb2.Duration = proto.Field(
Expand All @@ -342,6 +344,10 @@ class VideoMetadata(proto.Message):
number=2,
message=duration_pb2.Duration,
)
fps: float = proto.Field(
proto.DOUBLE,
number=3,
)


class PrebuiltVoiceConfig(proto.Message):
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/gapic/aiplatform_v1/test_gen_ai_tuning_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4630,6 +4630,7 @@ def test_create_tuning_job_rest_call_success(request_type):
"video_metadata": {
"start_offset": {"seconds": 751, "nanos": 543},
"end_offset": {},
"fps": 0.5,
},
}
],
Expand Down Expand Up @@ -6231,6 +6232,7 @@ async def test_create_tuning_job_rest_asyncio_call_success(request_type):
"video_metadata": {
"start_offset": {"seconds": 751, "nanos": 543},
"end_offset": {},
"fps": 0.5,
},
}
],
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/gapic/aiplatform_v1beta1/test_gen_ai_tuning_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4734,6 +4734,7 @@ def test_create_tuning_job_rest_call_success(request_type):
"video_metadata": {
"start_offset": {"seconds": 751, "nanos": 543},
"end_offset": {},
"fps": 0.5,
},
"thought": True,
"thought_signature": b"thought_signature_blob",
Expand Down Expand Up @@ -6485,6 +6486,7 @@ async def test_create_tuning_job_rest_asyncio_call_success(request_type):
"video_metadata": {
"start_offset": {"seconds": 751, "nanos": 543},
"end_offset": {},
"fps": 0.5,
},
"thought": True,
"thought_signature": b"thought_signature_blob",
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/gapic/aiplatform_v1beta1/test_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6791,6 +6791,7 @@ def test_append_event_rest_call_success(request_type):
"video_metadata": {
"start_offset": {"seconds": 751, "nanos": 543},
"end_offset": {},
"fps": 0.5,
},
"thought": True,
"thought_signature": b"thought_signature_blob",
Expand Down Expand Up @@ -8989,6 +8990,7 @@ async def test_append_event_rest_asyncio_call_success(request_type):
"video_metadata": {
"start_offset": {"seconds": 751, "nanos": 543},
"end_offset": {},
"fps": 0.5,
},
"thought": True,
"thought_signature": b"thought_signature_blob",
Expand Down