fix: added option to set fps in video metadata according to the documentation #6074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FPS option is missed in class VideoMetadata(proto.Message) in types/content.py
both in v1 and v1beta1
It should exist according to both docs (v1 and v1beta1):
https://cloud.google.com/vertex-ai/generative-ai/docs/reference/rest/v1/Content
https://cloud.google.com/vertex-ai/generative-ai/docs/reference/rest/v1beta1/Content
And also is existent in VideoMetadata in content.proto:
https://github.com/googleapis/googleapis/blob/97763d6efb2d35474e0363c254ee6994837a08fa/google/ai/generativelanguage/v1/content.proto#L107
I implemented it's support according to proto file and documentation.
Tested locally that library version with this changes is actually working by using less 'input_tokens'.
Also added using of fps field in few tests to the existing video_metadata object
Fixes #6073 🦕