Skip to content

Conversation

@Daniel-Aaron-Bloom
Copy link

@Daniel-Aaron-Bloom Daniel-Aaron-Bloom commented Aug 20, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Unfortunately google-auth-library doesn't yet support Cloud Run Job detection. The workaround is pretty simple (basically the same as #1024 did by checking the env directly). Happy to submit a future PR to do the "more correct" detection once support gets merged. Maybe someone here knows an approver over there 😁 .

Fixes #1590 🦕

@Daniel-Aaron-Bloom Daniel-Aaron-Bloom requested review from a team as code owners August 20, 2025 05:48
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/nodejs-logging API. labels Aug 20, 2025
@Daniel-Aaron-Bloom
Copy link
Author

@bhshkh Is there something I should do to rectify this? These errors look maybe related to #1599?

Also googleapis/google-auth-library-nodejs#2120 got merged, so I could bump google-auth-library to 10.3.0 and do the more proper fix. Any interest in that?

@bhshkh
Copy link
Contributor

bhshkh commented Sep 9, 2025

@bhshkh Is there something I should do to rectify this? These errors look maybe related to #1599?

Also googleapis/google-auth-library-nodejs#2120 got merged, so I could bump google-auth-library to 10.3.0 and do the more proper fix. Any interest in that?

@cindy-peng should be able to answer this.

@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Sep 19, 2025
@Daniel-Aaron-Bloom
Copy link
Author

Ping @cindy-peng

@bhshkh
Copy link
Contributor

bhshkh commented Sep 22, 2025

Tagging @danieljbruce @feywind

@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Oct 19, 2025
@Daniel-Aaron-Bloom
Copy link
Author

Ping.

@miguelvelezsa
Copy link

miguelvelezsa commented Oct 30, 2025

Hi @Daniel-Aaron-Bloom! thanks for your help on this. Yes, I think upgrading auth is the most proper solution + will help with #1592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/nodejs-logging API. size: m Pull request size is medium. stale: extraold Pull request is critically old and needs prioritization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logging.detectedResource does not return "cloud_run_job" on Cloud Run Job

4 participants