Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

build(tests): remove vm after test #644

Merged
merged 6 commits into from
Sep 2, 2022
Merged

Conversation

wutonggg
Copy link
Contributor

@wutonggg wutonggg commented Aug 15, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [] Ensure the tests and linter pass
  • [] Code coverage does not decrease (if any source code was changed)
  • [] Appropriate docs were updated (if necessary)

Fixes #641 🦕

@wutonggg wutonggg requested review from a team as code owners August 15, 2022 19:32
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: cloudasset Issues related to the googleapis/nodejs-asset API. labels Aug 15, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 15, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@wutonggg wutonggg marked this pull request as draft August 15, 2022 20:00
@wutonggg wutonggg marked this pull request as ready for review August 15, 2022 20:01
@sofisl sofisl changed the title fix: remove vm after test build(tests): remove vm after test Aug 24, 2022
@wutonggg
Copy link
Contributor Author

Thanks sofisl for help make the PR green!

@wutonggg wutonggg added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 2, 2022
@wutonggg wutonggg merged commit e55ebf1 into googleapis:main Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudasset Issues related to the googleapis/nodejs-asset API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samples test should delete created VMs
3 participants