Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

samples test should delete created VMs #641

Closed
alexander-fenster opened this issue Jul 19, 2022 · 0 comments · Fixed by #644
Closed

samples test should delete created VMs #641

alexander-fenster opened this issue Jul 19, 2022 · 0 comments · Fixed by #644
Assignees
Labels
api: cloudasset Issues related to the googleapis/nodejs-asset API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@alexander-fenster
Copy link
Contributor

Samples tests create VMs named asset-nodejs-* and they don't get deleted. Need to make sure the sample test deletes stale VMs.

./nodejs-asset/samples/test/sample.test.js:const bucketName = `asset-nodejs-${uuid.v4()}`;
./nodejs-asset/samples/test/sample.test.js:    instanceName = `asset-nodejs-${uuid.v4()}`;
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudasset Issues related to the googleapis/nodejs-asset API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants