Skip to content

fix: improve 503 handling for json resumable queries#2977

Closed
sfc-gh-mwnukowski wants to merge 1 commit intogoogleapis:mainfrom
sfc-gh-mwnukowski:main
Closed

fix: improve 503 handling for json resumable queries#2977
sfc-gh-mwnukowski wants to merge 1 commit intogoogleapis:mainfrom
sfc-gh-mwnukowski:main

Conversation

@sfc-gh-mwnukowski
Copy link
Contributor

@sfc-gh-mwnukowski sfc-gh-mwnukowski commented Mar 7, 2025

This is exactly the same as #2289 - seem like a duplicated code that diverged.

Fixes a rare 503 handling issue

...
caused by NullPointerException: Cannot invoke "String.toLowerCase(java.util.Locale)" because the return value of "com.google.api.client.http.HttpResponseException.getContent()" is null
...
com.google.cloud.storage.JsonResumableSessionQueryTask.call(JsonResumableSessionQueryTask.java:117)
com.google.cloud.storage.JsonResumableSession.query(JsonResumableSession.java:57)
caused by StorageException: Unknown Error
	|> PUT https://storage.googleapis.com/upload/storage/v1/b/gcpeuropewest4-gcpeuropewest3-e942/o?name=<...>
	|> content-range: bytes */*
	|> x-goog-gcs-idempotency-token: <...>
	|  
	|< HTTP/1.1 503 Service Unavailable
	|< content-length: 0
	|< content-type: text/plain; charset=utf-8
	|< x-guploader-uploadid: <...>
	|  

cc @BenWhitehead

@sfc-gh-mwnukowski sfc-gh-mwnukowski requested a review from a team March 7, 2025 02:10
@google-cla
Copy link

google-cla bot commented Mar 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Mar 7, 2025
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2025
@BenWhitehead
Copy link
Collaborator

Hi @sfc-gh-mwnukowski, thanks for opening this PR. A similar PR was opened as well, except that one has a test added along with it #2987

I'm going to close out this PR without merging, however I'm going to add you as a co-author on the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants