chore: update owlbot yaml to match generated folder structure#2620
Merged
diegomarquezp merged 1 commit intomainfrom Jul 2, 2024
Merged
chore: update owlbot yaml to match generated folder structure#2620diegomarquezp merged 1 commit intomainfrom
diegomarquezp merged 1 commit intomainfrom
Conversation
product-auto-label
bot
added
size: xs
JoeWang1127
previously approved these changes
Jul 2, 2024
JoeWang1127
reviewed
Jul 2, 2024
| - source: "/google/storage/v2/.*-java/gapic-google-.*/src" | ||
| dest: "/owl-bot-staging/v2/gapic-google-cloud-storage-v2/src" | ||
| - source: "/google/storage/v2/google-cloud-storage-v2-java/gapic-google-cloud-storage-v2-java/src/main/java/com/google/storage/v2/gapic_metadata.json" | ||
| - source: "/google/storage/v2/.*-java/gapic-google-.*/src/main/java/com/google/storage/v2/gapic_metadata.json" |
Contributor
There was a problem hiding this comment.
Do you know why gapic_metadata.json is not included by the previous entry?
Contributor
Author
There was a problem hiding this comment.
It's from a commit back in January 2dec9d4
It makes sense that the previous entry should bring it, but it doesn't
Contributor
There was a problem hiding this comment.
This entry means to move gapic_metadata.json from main/java to main/resources.
Looks like a library specific post processing.
Contributor
Author
There was a problem hiding this comment.
Yes, thank you. I oversaw this is a copy query into resources.
BenWhitehead
approved these changes
Jul 2, 2024
JoeWang1127
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/googleapis/java-storage/pull/2619/files#r1662929781