fix: create stub with BigtableClientContext so otels are closed #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
mutianf
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java
Outdated
Show resolved
Hide resolved
igorbernstein2
approved these changes
Jan 6, 2026
blakeli0
added a commit
that referenced
this pull request
Feb 3, 2026
* tests: Remove unnecessary null check for protobuf lists (#2723) ErrorProne will complain ImpossibleNullComparison once protobuf runtime is upgraded to 4.x. See the downstream tests in sdk-platform-java. * chore: add release-please config for protobuf-4.x (#2722) * chore: add release-please config for protobuf-4.x * chore: generate libraries at Wed Dec 3 18:40:37 UTC 2025 * chore: enable manifest option in release config --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com> * deps: update shared dependencies (#2734) * chore(main): release 2.70.1-SNAPSHOT (#2715) * chore(main): release 2.70.1-SNAPSHOT * chore: generate libraries at Fri Dec 12 14:04:07 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com> * chore(main): release 2.70.1 (#2735) * chore(main): release 2.70.1 * chore: generate libraries at Fri Dec 12 15:48:36 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com> * fix(bigtable): add handling for gauge metrics (#2719) * fix(bigtable): add handling for gauge metrics * add it * chore: generate libraries at Tue Nov 25 20:15:38 UTC 2025 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com> * chore(main): release 2.70.2-SNAPSHOT (#2736) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * feat: Add CSM for batch write flow control (#2685) * test: Add missing test table cleanup for MaterializedViewIT (#2721) Change-Id: I1281568894ac2d04f0aafe0aa7f4efa7570ae58a Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md). * tests: Migrate usage of GeneratedMessageV3 to Message (#2745) * tests: Migrate usage of GeneratedMessageV3 to Message * chore: generate libraries at Mon Dec 22 22:29:53 UTC 2025 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com> * fix: create stub with BigtableClientContext so otels are closed (#2747) * fix: create stub with BigtableClientContext so otels are closed * address comment * test: Reduce ExecuteQueryIT flakiness with a retry loop (#2748) Change-Id: I4171e5b11d2278a8b3dc19d2dec3f03d784759ce * fix: use the same background executor in otel reader and monitoring c… (#2746) * fix: use the same background executor in otel reader and monitoring client * add public api doc * fix tests * close background executor * fix test * address comments * fix * deps: update shared dependencies (#2752) * fix: update BigtableChannelPool to use the background executor (#2753) * deps: update dependency com.google.cloud:gapic-libraries-bom to v1.76.0 (#2754) * chore(main): release 2.71.0 (#2737) * chore(main): release 2.71.0 * chore: generate libraries at Thu Jan 15 16:06:19 UTC 2026 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com> --------- Co-authored-by: Diego Marquez <diegomarquezp@google.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Sushan Bhattarai <sushantsusan@google.com> Co-authored-by: Weihan Kong <kongweihan@users.noreply.github.com> Co-authored-by: Lixia Chen <trollyxia@gmail.com> Co-authored-by: Mattie Fu <mattiefu@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
EnhancedBigtableStubwithBigtableClientContext. Before the change when EnhancedBigtableStub is cloesd, it only calls close on the background resources inClientContext. However otel and internal otel are created on BigtableClientContext and nothing calls it to close them.