Skip to content

fix: use the same background executor in otel reader and monitoring c… #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mutianf merged 8 commits into from
Jan 7, 2026
Merged

fix: use the same background executor in otel reader and monitoring c… #2746

mutianf merged 8 commits into from
Jan 7, 2026

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Dec 23, 2025 •
edited
Loading

…lient

Use the same background executor in monitoring client and OpenTelemetry Periodic readers as the bigtable client. This executor is only used for background tasks, so monitoring client is still gonna have different executors for its channels.

Since we convert the background executor to a fixed executor provider, we need to add it back to the background resources to auto close it.

@mutianf mutianf requested review from a team as code owners December 23, 2025 02:37
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 23, 2025
@mutianf mutianf requested a review from a team as a code owner December 23, 2025 17:15
igorbernstein2
igorbernstein2 previously approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after comments are addressed

igorbernstein2
igorbernstein2 reviewed Jan 5, 2026
View reviewed changes
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
// if the background executor in the settings is already a FixedExecutorProvider,
// we can't assume that we can autoclose it and the life cycle should be managed
// by the application
canAutoCloseExecutor = false;
Copy link
Contributor

@igorbernstein2 igorbernstein2 Jan 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create our own implementation of the ExecutorProvider with a settable bit for shouldAutoClose and use that instead of the FixedExecutorProvider? This way we can localize the lifecycle management instead of messing around with background resources?

But still passing a FixedExecutorProvider to the child clients like metrics?

@mutianf mutianf merged commit 3a58f9b into googleapis:main Jan 7, 2026
25 checks passed
@mutianf mutianf deleted the thread1 branch January 7, 2026 18:29
@release-please release-please bot mentioned this pull request Jan 6, 2026
Merged
blakeli0 added a commit that referenced this pull request Feb 3, 2026
@blakeli0 @diegomarquezp
@cloud-java-bot @renovate-bot @release-please @sushanb @kongweihan @trollyxia @mutianf
chore: Merge release v2.71.0 into protobuf-3.x (#2771)
2e10f0b 
* tests: Remove unnecessary null check for protobuf lists (#2723)

ErrorProne will complain ImpossibleNullComparison once protobuf runtime is upgraded to 4.x. See the downstream tests in sdk-platform-java.

* chore: add release-please config for protobuf-4.x (#2722)

* chore: add release-please config for protobuf-4.x

* chore: generate libraries at Wed Dec  3 18:40:37 UTC 2025

* chore: enable manifest option in release config

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

* deps: update shared dependencies (#2734)

* chore(main): release 2.70.1-SNAPSHOT (#2715)

* chore(main): release 2.70.1-SNAPSHOT

* chore: generate libraries at Fri Dec 12 14:04:07 UTC 2025

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

* chore(main): release 2.70.1 (#2735)

* chore(main): release 2.70.1

* chore: generate libraries at Fri Dec 12 15:48:36 UTC 2025

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

* fix(bigtable): add handling for gauge metrics (#2719)

* fix(bigtable): add handling for gauge metrics

* add it

* chore: generate libraries at Tue Nov 25 20:15:38 UTC 2025

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

* chore(main): release 2.70.2-SNAPSHOT (#2736)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat: Add CSM for batch write flow control (#2685)

* test: Add missing test table cleanup for MaterializedViewIT (#2721)

Change-Id: I1281568894ac2d04f0aafe0aa7f4efa7570ae58a

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Rollback plan is reviewed and LGTMed
- [ ] All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the [samples format](
https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).

* tests: Migrate usage of GeneratedMessageV3 to Message (#2745)

* tests: Migrate usage of GeneratedMessageV3 to Message

* chore: generate libraries at Mon Dec 22 22:29:53 UTC 2025

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

* fix: create stub with BigtableClientContext so otels are closed (#2747)

* fix: create stub with BigtableClientContext so otels are closed

* address comment

* test: Reduce ExecuteQueryIT flakiness with a retry loop (#2748)

Change-Id: I4171e5b11d2278a8b3dc19d2dec3f03d784759ce

* fix: use the same background executor in otel reader and monitoring c… (#2746)

* fix: use the same background executor in otel reader and monitoring client

* add public api doc

* fix tests

* close background executor

* fix test

* address comments

* fix

* deps: update shared dependencies (#2752)

* fix: update BigtableChannelPool to use the background executor (#2753)

* deps: update dependency com.google.cloud:gapic-libraries-bom to v1.76.0 (#2754)

* chore(main): release 2.71.0 (#2737)

* chore(main): release 2.71.0

* chore: generate libraries at Thu Jan 15 16:06:19 UTC 2026

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

---------

Co-authored-by: Diego Marquez <diegomarquezp@google.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Sushan Bhattarai <sushantsusan@google.com>
Co-authored-by: Weihan Kong <kongweihan@users.noreply.github.com>
Co-authored-by: Lixia Chen <trollyxia@gmail.com>
Co-authored-by: Mattie Fu <mattiefu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mutianf @igorbernstein2