Skip to content

test: deflake prepare plan refresh timeout test #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackdingilian merged 2 commits into from
Jul 16, 2025
Merged

test: deflake prepare plan refresh timeout test #2628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62377ec
test: deflake prepare plan refresh timeout test
jackdingilian Jul 15, 2025
51c7ba9
Merge branch 'main' into deflake-prepare-test
jackdingilian Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .../src/test/java/com/google/cloud/bigtable/data/v2/stub/sql/PlanRefreshingCallableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,10 @@ public void planRefreshDelayIsFactoredIntoExecuteTimeout() throws InterruptedExc
ExecuteQueryCallContext callContext =
ExecuteQueryCallContext.create(preparedStatement.bind().build(), metadataFuture);

Duration originalAttemptTimeout = Duration.ofMillis(100);
// This deadline is used for the prepare call and the ultimate execute call after
// that completes. It needs to leave a lot of margin for error for the scheduler below to
// be slower than expected to resolve. Previously 100ms deadline was not enough.
Duration originalAttemptTimeout = Duration.ofMillis(5000);
scheduler.schedule(
() -> {
prepareFuture.set(
Expand All @@ -278,6 +281,9 @@ public void planRefreshDelayIsFactoredIntoExecuteTimeout() throws InterruptedExc
callable.call(callContext, outerObserver, context);
scheduler.shutdown();
scheduler.awaitTermination(30, TimeUnit.SECONDS);
// Make sure prepare didn't time out and return an error.
// Otherwise, the observer should not be done
assertFalse(outerObserver.isDone());
GrpcCallContext grpcCallContext =
(GrpcCallContext) innerCallable.popLastCall().getApiCallContext();
Deadline executeDeadline = grpcCallContext.getCallOptions().getDeadline();
Expand Down
Loading