Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure bucket delete does not fail in regression tests. #563

Merged
merged 1 commit into from
Jan 22, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 22, 2015

Adds a safe_delete() which respects objects which are still listed for a bucket but have already been deleted. (This is because the object list is eventually consistent and we delete some objects in our regression tests.)

Fixes #531. See #535 for context.

Fix based on comment from @thobrla.

This is a "temporary" stop-gap and the safe delete can likely be folded into Connection.delete_bucket(). For now, we want to eliminate flaky regression test failures.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2015
@dhermes dhermes force-pushed the storage-safe-teardown branch from 1c43f92 to 0b90362 Compare January 22, 2015 20:10
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0b90362 on dhermes:storage-safe-teardown into 927c534 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0b90362 on dhermes:storage-safe-teardown into 927c534 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Jan 22, 2015

LGTM

dhermes added a commit that referenced this pull request Jan 22, 2015
Making sure delete does not fail in regression tests.
@dhermes dhermes merged commit 86acc4a into googleapis:master Jan 22, 2015
@dhermes dhermes deleted the storage-safe-teardown branch January 22, 2015 21:13
@dhermes
Copy link
Contributor Author

dhermes commented Jan 22, 2015

Hilariously, this regression test failed due to flakiness:
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/47970589

======================================================================
FAIL: test_save_key_self_reference (datastore.TestDatastoreSaveKeys)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/GoogleCloudPlatform/gcloud-python/regression/datastore.py", line 158, in test_save_key_self_reference
    self.assertEqual(len(stored_persons), 1)
AssertionError: 0 != 1

I "fixed" this in #562 but it seems I didn't fully, FULLY understand the eventual consistency issue.

@dhermes dhermes changed the title Making sure delete does not fail in regression tests. Making sure bucket delete does not fail in regression tests. Jan 22, 2015
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Source-Link: googleapis/synthtool@703554a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b
parthea pushed a commit that referenced this pull request Oct 21, 2023
…y for google/cloud/asset/v1 (#563)

* chore(python): Add google.cloud.osconfig.v1 as a proto-plus dependency for google/cloud/asset/v1

PiperOrigin-RevId: 523506983

Source-Link: googleapis/googleapis@6f5d107

Source-Link: googleapis/googleapis-gen@594fcc2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTk0ZmNjMmFlZWY1YTM4ZmJiOTU3NWRmODRlYmUzYjhkZDdmYmEwNSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@dede53f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fac304457974bb530cc5396abd4ab25d26a469cd3bc97cbfb18c8d4324c584eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build in regression test case retries
4 participants