-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making sure bucket delete does not fail in regression tests. #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jan 22, 2015
Fixes googleapis#531. See googleapis#535 for context.
dhermes
force-pushed
the
storage-safe-teardown
branch
from
January 22, 2015 20:10
1c43f92
to
0b90362
Compare
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 22, 2015
Making sure delete does not fail in regression tests.
Hilariously, this regression test failed due to flakiness:
I "fixed" this in #562 but it seems I didn't fully, FULLY understand the eventual consistency issue. |
dhermes
changed the title
Making sure delete does not fail in regression tests.
Making sure bucket delete does not fail in regression tests.
Jan 22, 2015
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
Source-Link: googleapis/synthtool@703554a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…y for google/cloud/asset/v1 (#563) * chore(python): Add google.cloud.osconfig.v1 as a proto-plus dependency for google/cloud/asset/v1 PiperOrigin-RevId: 523506983 Source-Link: googleapis/googleapis@6f5d107 Source-Link: googleapis/googleapis-gen@594fcc2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTk0ZmNjMmFlZWY1YTM4ZmJiOTU3NWRmODRlYmUzYjhkZDdmYmEwNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Source-Link: googleapis/synthtool@dede53f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fac304457974bb530cc5396abd4ab25d26a469cd3bc97cbfb18c8d4324c584eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
safe_delete()
which respects objects which are still listed for a bucket but have already been deleted. (This is because the object list is eventually consistent and we delete some objects in our regression tests.)Fixes #531. See #535 for context.
Fix based on comment from @thobrla.
This is a "temporary" stop-gap and the safe delete can likely be folded into
Connection.delete_bucket()
. For now, we want to eliminate flaky regression test failures.