Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build in regression test case retries #531

Closed
dhermes opened this issue Jan 10, 2015 · 2 comments · Fixed by #563
Closed

Build in regression test case retries #531

dhermes opened this issue Jan 10, 2015 · 2 comments · Fixed by #563
Assignees
@dhermes
Labels
testing

Comments

@dhermes
Copy link
Contributor

dhermes commented Jan 10, 2015

Add in one retry for network failures to reduce (eliminate?) flaky / intermittent failures.

For example
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/46346592
after #509 failed on code that didn't even change in the PR.
@dhermes dhermes self-assigned this Jan 12, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 12, 2015
@dhermes
Attempt retry hook for flaky regression test cases.
62da2d5 
Fixes googleapis#531.

To "test" that this works, feel free to add a test case like:

    x = 0

    def test_retry(self):
        # Feel free to vary 3 higher and higher, should always be
        # NUM_RETRIES in the final error message.
        if self.x < 3:
            self.x += 1
            self.assertEqual(self.x, object())  # Fails
        else:
            self.assertTrue(True)
@dhermes
Copy link
Contributor Author

dhermes commented Jan 12, 2015

See https://github.com/dhermes/gcloud-python/tree/retry-flaky-regression-cases, will submit PR

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 12, 2015
@dhermes
Attempt retry hook for flaky regression test cases.
605ed86 
Fixes googleapis#531.

To "test" that this works, feel free to add a test case like:

    x = 0

    def test_retry(self):
        # Feel free to vary 3 higher and higher, should always be
        # NUM_RETRIES in the final error message.
        if self.x < 3:
            self.x += 1
            self.assertEqual(self.x, object())  # Fails
        else:
            self.assertTrue(True)
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 12, 2015
@dhermes
Attempt retry hook for flaky regression test cases.
09431a8 
Fixes googleapis#531.

To "test" that this works, feel free to add a test case like:

    x = 0

    def test_retry(self):
        # Feel free to vary 3 higher and higher, should always be
        # NUM_RETRIES in the final error message.
        if self.x < 3:
            self.x += 1
            self.assertEqual(self.x, object())  # Fails
        else:
            self.assertTrue(True)
@dhermes dhermes mentioned this issue Jan 12, 2015
Closed
@dhermes
Copy link
Contributor Author

dhermes commented Jan 14, 2015

Another regression failure:
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/46219691

This one is actually a test failure (F) instead of an error (E) caused by a network 404 as above.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 15, 2015
@dhermes
Attempt retry hook for flaky regression test cases.
1741bbb 
Fixes googleapis#531.

To "test" that this works, feel free to add a test case like:

    x = 0

    def test_retry(self):
        # Feel free to vary 3 higher and higher, should always be
        # NUM_RETRIES in the final error message.
        if self.x < 3:
            self.x += 1
            self.assertEqual(self.x, object())  # Fails
        else:
            self.assertTrue(True)
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 15, 2015
@dhermes
Attempt retry hook for flaky regression test cases.
012fd2c 
Fixes googleapis#531.

To "test" that this works, feel free to add a test case like:

    x = 0

    def test_retry(self):
        # Feel free to vary 3 higher and higher, should always be
        # NUM_RETRIES in the final error message.
        if self.x < 3:
            self.x += 1
            self.assertEqual(self.x, object())  # Fails
        else:
            self.assertTrue(True)
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 22, 2015
@dhermes
Making sure delete does not fail in regression tests.
1c43f92 
Fixes googleapis#531. See googleapis#535 for context.
@dhermes dhermes mentioned this issue Jan 22, 2015
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 22, 2015
@dhermes
Making sure delete does not fail in regression tests.
0b90362 
Fixes googleapis#531. See googleapis#535 for context.
@jgeewax jgeewax modified the milestone: Core Stable Jan 30, 2015
parthea pushed a commit that referenced this issue Aug 15, 2023
@gcf-owl-bot
feat(v3beta1): added GitIntegrationSettings to the Agent (#531)
22a627b 
* feat: added GitIntegrationSettings to the Agent

PiperOrigin-RevId: 546355900

Source-Link: googleapis/googleapis@dc3d3a2

Source-Link: googleapis/googleapis-gen@2480a9f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ4MGE5ZjhiZmJjNzk4N2Y1ODNkNzBlMTk5NTg0YTQ2YjUyMTMzZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this issue Sep 20, 2023
@gcf-owl-bot
chore: add prerelease nox session (#531)
c12e3e0 
Source-Link: googleapis/synthtool@050953d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Sep 22, 2023
@parthea @gcf-owl-bot @suztomo
chore: Prepare for mono repository migration (#531)
9e5744e 
* chore: Prepare for mono repository migration

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Tomo Suzuki <suztomo@gmail.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-resource-manager to v1.8.0 (
1eeb035 
#531)
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
build(deps): bump cryptography from 38.0.3 to 39.0.1 in /synthtool/gc…
a2feb10 
…p/templates/python_library/.kokoro (#531)

Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
build(deps): bump requests from 2.28.1 to 2.31.0 in /synthtool/gcp/te…
4196372 
…mplates/python_library/.kokoro (#531)

Source-Link: googleapis/synthtool@30bd01b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump pygments from 2.13.0 to 2.15.0 (#531)
63f23df 
Source-Link: googleapis/synthtool@eaef28e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
testing
Projects
None yet
Milestone
No milestone
2 participants
@jgeewax @dhermes