Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TimestampNanoSeconds to api_core #4979

Merged
merged 3 commits into from
Mar 9, 2018
Merged

Move TimestampNanoSeconds to api_core #4979

merged 3 commits into from
Mar 9, 2018

Conversation

chemelnucfin
Copy link
Contributor

Closes #4829

@chemelnucfin chemelnucfin added api: core api: spanner Issues related to the Spanner API. type: process A process-related concern. May include testing, release, or the like. labels Feb 28, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2018
theacodes
theacodes suggested changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the changes to spanner in a separate PR?

api_core/google/api_core/datetime_helpers.py Outdated
nanosecond=nanos, tzinfo=UTC)


class _UTC(datetime.tzinfo):

This comment was marked as spam.

Sign in to view

api_core/google/api_core/datetime_helpers.py
nanos = kw.pop('nanosecond', 0)
if nanos > 0:
if 'microsecond' in kw:
raise TypeError(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

api_core/google/api_core/datetime_helpers.py
__slots__ = ('_nanosecond',)

# pylint: disable=arguments-differ
def __new__(cls, *args, **kw):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

api_core/google/api_core/datetime_helpers.py Outdated
return self._nanosecond

def rfc3339(self):
"""RFC 3339-compliant timestamp.

This comment was marked as spam.

Sign in to view

api_core/google/api_core/datetime_helpers.py Outdated
def rfc3339(self):
"""RFC 3339-compliant timestamp.

:rtype: str

This comment was marked as spam.

Sign in to view

api_core/google/api_core/datetime_helpers.py Outdated
if self._nanosecond == 0:
return to_rfc3339(self)
nanos = str(self._nanosecond).rstrip('0')
return '%s.%sZ' % (self.strftime(_RFC3339_NO_FRACTION), nanos)

This comment was marked as spam.

Sign in to view

api_core/tests/unit/test_datetime_helpers.py Outdated
@@ -13,6 +13,7 @@
# limitations under the License.

import datetime
import unittest

This comment was marked as spam.

Sign in to view

@chemelnucfin chemelnucfin force-pushed the timestamp_to_api_core branch 2 times, most recently from d386fd0 to 414f86a Compare March 1, 2018 02:26
This was referenced Mar 1, 2018
Merged
Merged
theacodes
theacodes suggested changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooking pretty close, just a few more nits.

api_core/tests/unit/test_datetime_helpers.py Outdated


def test_timestampwithnanos_from_rfc3339_wo_fraction():
from google.api_core import datetime_helpers

This comment was marked as spam.

Sign in to view

api_core/tests/unit/test_datetime_helpers.py Outdated
def test_timestampwithnanos_from_rfc3339_wo_fraction():
from google.api_core import datetime_helpers

klass = datetime_helpers.TimestampWithNanoseconds

This comment was marked as spam.

Sign in to view

theacodes
theacodes suggested changes Mar 9, 2018
View reviewed changes
api_core/google/api_core/datetime_helpers.py Outdated
@@ -179,3 +179,71 @@ def to_rfc3339(value, ignore_zone=True):
value = value.replace(tzinfo=None) - value.utcoffset()

return value.strftime(_RFC3339_MICROS)


class TimestampWithNanoseconds(datetime.datetime):

This comment was marked as spam.

Sign in to view

@chemelnucfin chemelnucfin merged commit ed3c300 into googleapis:master Mar 9, 2018
@chemelnucfin chemelnucfin deleted the timestamp_to_api_core branch March 9, 2018 23:58
@tseaver tseaver mentioned this pull request Mar 16, 2018
Closed
@tswast tswast mentioned this pull request Jul 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@theacodes theacodes theacodes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: core api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chemelnucfin @tseaver @theacodes @googlebot