-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtimeconfig: Update time fails to parse #4807
Comments
Interesting. RuntimeConfig must have started recording nanoseconds somewhat recently. @jonparrott It seems Python only supports microsecond precision, not nanoseconds. I'm guessing we should modify the parsing to discard nanoseconds when present. |
@tswast FWIW, spanner has a non-public |
promote it into api_core? It might be useful because many APIs do expose nanosecond precision. |
The from_rfc3339 function there looks very useful. I would bet that more GCP products will be doing nanoseconds. |
@tseaver do you mind filing a bug to promote that class to api_core? (& if you or @chemelnucfin |
@jonparrott see #4829. |
PR #4979 moved that class into API core, so we should be able to fix this issue using it. |
OS: Linux (Debian 4.9.65)
Python: 3.5.3 / 2.7.13
Version: google-cloud-runtimeconfig==0.28.0, google-cloud==0.32.0
Steps to reproduce:
Observation: The
%f
format accepts microseconds, not fractions of arbitrary precision. That means six digits at most, but I see nine in the data.The text was updated successfully, but these errors were encountered: