Re-enable 'Bucket.requester_pays' feature #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
api: storage
googlebot
added
the
cla: yes
|
@tseaver How much of this has been reviewed and how much is new? (Sorry if that is a question I should know the answer to.) |
|
@dhermes This was all reviewed back in June: I just re-built the branch because the reversion made it hard to see what would be landed this time. |
|
@tseaver Great. So no review needed? |
|
@dhermes Not until we resolve whether / how we will implement the additional system tests. |
tseaver
force-pushed
the
storage-requester_pays-feature
branch
2 times, most recently
from
d34dfe5 to
ec34758
Compare
|
@lukesneeringer I believe that this branch is ready to merge to
|
tseaver
removed
the
do not merge
|
Unrelated AppVeyor failure (see #4128). |
|
@lukesneeringer AFAIK, this branch is ready to merge. |
tseaver
force-pushed
the
storage-requester_pays-feature
branch
from
ec34758 to
41fca6f
Compare
Also, add 'requester_pays' argument to 'Client.create_bucket'. Add a system test which exercises the feature. Note that the new system test is skipped, because 'Buckets.insert' fails with the 'billing/requesterPays' field set, both in our system tests and in the 'Try It!' form in the docs. Toward #3474.
* Add abstract '_PropertyMixin.user_project' property.
* Support 'user_project' in '_PropertyMixin.{reload,patch}'.
* Add 'user_project' param to 'Bucket.__init__'.
* Save and expose via read-only 'user_project' property.
* Implement 'Blob.user_property' via bucket's value.
* Block 'Bucket.create' if 'user_project' set: the API does not accept that parameter.
Back-end used to reject it, but now allows it.
…ct' set (#4084) * Pass through extra posargs for system tests. * Plumb 'user_project' arg through 'Client.bucket'.
Test 'Blob.rewrite' w/ 'user_project' set.
tseaver
force-pushed
the
storage-requester_pays-feature
branch
from
41fca6f to
b0e1c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3474.
Needs extra system tests which pass
user_projectto the various APIs which take it, in the context of a bucket which is created withrequester_paysenabled.