Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass 'user_project' if set for BucketACL/BlobACL API requests #3499

Merged
merged 3 commits into from
Jun 13, 2017
Merged

Pass 'user_project' if set for BucketACL/BlobACL API requests #3499

merged 3 commits into from
Jun 13, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 13, 2017

Toward #3474.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 13, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2017
@tseaver tseaver mentioned this pull request Jun 13, 2017
Closed
dhermes
dhermes approved these changes Jun 13, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I am surprised the ACL's need to care

@tseaver tseaver merged commit f14bde3 into googleapis:master Jun 13, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Jun 13, 2017

Somebody still gets charged, even for updating / querying ACLs. :)

@tseaver tseaver deleted the 3474-storage-requester_pays-acl branch June 13, 2017 19:51
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@tseaver @landrito
Pass 'user_project' if set for BucketACL/BlobACL API requests (google…
c0e8745 
…apis#3499)
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Pass 'user_project' if set for BucketACL/BlobACL API requests (google…
41b6b98 
…apis#3499)
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Pass 'user_project' if set for BucketACL/BlobACL API requests (google…
da2c11f 
…apis#3499)
tseaver added a commit that referenced this pull request Sep 22, 2017
@tseaver
Pass 'user_project' if set for BucketACL/BlobACL API requests (#3499)
74ecfa5
tseaver added a commit that referenced this pull request Oct 2, 2017
@tseaver
Pass 'user_project' if set for BucketACL/BlobACL API requests (#3499)
177d28f
tseaver added a commit that referenced this pull request Oct 5, 2017
@tseaver
Pass 'user_project' if set for BucketACL/BlobACL API requests (#3499)
4f338b0
tseaver added a commit that referenced this pull request Oct 10, 2017
@tseaver
Pass 'user_project' if set for BucketACL/BlobACL API requests (#3499)
020a3d7
tseaver added a commit that referenced this pull request Oct 10, 2017
@tseaver
Pass 'user_project' if set for BucketACL/BlobACL API requests (#3499)
552e35f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot