Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for pubsub scope error. #2909

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Fix for pubsub scope error. #2909

merged 1 commit into from
Jan 3, 2017

Conversation

daspecster
Copy link
Contributor

Closes #2908

I'm not sure this is the right way to go about fixing this. But it works!

@daspecster daspecster added the api: pubsub Issues related to the Pub/Sub API. label Dec 29, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 29, 2016
@dhermes
Copy link
Contributor

dhermes commented Dec 29, 2016

Indeed. DERP!

I was assuming that (also here)

client._credentials is client._connection._credentials

in #2874 (and maybe #2875). But that isn't true: the Connection constructor calls google.auth.credentials.with_scopes_if_required.

@dhermes
Copy link
Contributor

dhermes commented Dec 29, 2016

@daspecster I'm not really sure what to do here. Pub/Sub and Logging are "half-way" to just removing Connection altogether (or having a very different / stripped down version of the Connection). So this change needed to be made as part of that effort, the effort just got halted by Santa.

@daspecster
Copy link
Contributor Author

daspecster commented Dec 29, 2016 •
edited
Loading

🎅 💥

Ok, I can try and continue with the "extraction". But if you want too, I'll close this and keep rolling with other things.

Edit: I just realized that my emoji look like I'm blowing up santa...I was going for Santa blowing up pubsub and logging...ha

@dhermes
Copy link
Contributor

dhermes commented Jan 3, 2017

@daspecster I think the right fix (for now) is to just use client._connection._credentials (here and here).

@daspecster
Copy link
Contributor Author

Update pushed! I ran the system tests and they passed so that should do the trick!

@dhermes
Copy link
Contributor

dhermes commented Jan 3, 2017

👍 LGTM to merge (Travis is green already)

@daspecster daspecster merged commit 61d63e5 into googleapis:master Jan 3, 2017
@daspecster daspecster deleted the fix-pubsub-grpc-credentials branch January 3, 2017 17:14
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Jan 12, 2017
@dhermes
Fixing credentials without scopes issue in logging.
8675e88 
See:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/191433056#L2195

This is a band-aid for now. I caused it in googleapis#2875 and will roll-back this
roll-back at a later time.

@daspecter fixed a similar breakage in googleapis#2909.
@dhermes dhermes mentioned this pull request Jan 12, 2017
Merged
@dhermes dhermes mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Merge pull request googleapis#2909 from daspecster/fix-pubsub-grpc-cr…
cc10ac3 
…edentials

Fix for pubsub scope error.
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Fixing credentials without scopes issue in logging.
b0dfd7b 
See:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/191433056#L2195

This is a band-aid for now. I caused it in googleapis#2875 and will roll-back this
roll-back at a later time.

@daspecter fixed a similar breakage in googleapis#2909.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gRPC pubsub missing scope error
4 participants
@daspecster @dhermes @tseaver @googlebot