Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing credentials without scopes issue in logging. #2934

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 12, 2017

See:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/191433056#L2195

This is a band-aid for now. I caused it in #2875 and will roll-back this roll-back at a later time.

@daspecster fixed a similar breakage in #2909.

See:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/191433056#L2195

This is a band-aid for now. I caused it in googleapis#2875 and will roll-back this
roll-back at a later time.

@daspecter fixed a similar breakage in googleapis#2909.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2017
@dhermes dhermes added api: logging Issues related to the Cloud Logging API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 12, 2017
@daspecster
Copy link
Contributor

Travis is just finishing up, but it LGTM.

@dhermes dhermes merged commit 87879d0 into googleapis:master Jan 12, 2017
@dhermes dhermes deleted the fix-2875-brkage branch January 12, 2017 23:07
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Fixing credentials without scopes issue in logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants