Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing use of wheelhouse and relying on Travis caching. #1350

Merged
merged 1 commit into from
Jan 7, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ system_tests/local_test_setup
# Make sure a generated file isn't accidentally committed.
pylintrc_reduced

# Travis build directories.
gcloud-python-wheels/

# Directories used for creating generated PB2 files
generated_python/
cloud-bigtable-client/
12 changes: 6 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
language: python
sudo: false

before_install:
- git clone https://github.com/GoogleCloudPlatform/gcloud-python-wheels
gcloud-python-wheels
- export WHEELHOUSE="$(pwd)/gcloud-python-wheels/wheelhouse/"

install:
- scripts/custom_pip_install.sh tox
- pip install --upgrade pip
- pip install --upgrade tox

script:
- tox -e py26
Expand All @@ -32,3 +28,7 @@ deploy:
# until this is fixed: https://github.com/travis-ci/travis-ci/issues/1675
all_branches: true
distributions: "sdist bdist_wheel"

cache:
directories:
- ${HOME}/.cache/pip
22 changes: 9 additions & 13 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -283,22 +283,18 @@ Python dependencies are specified in the ``tox.ini`` configuration.
They are executed in the Travis build via ``tox -e {ENV}`` where
``{ENV}`` is the environment being tested.

By enumerating all Python dependencies in the ``tox`` configuration,
we can use our custom ``gcloud-python-wheels``
`wheelhouse <https://github.com/GoogleCloudPlatform/gcloud-python-wheels>`__
to speed up builds. This project builds and stores pre-built Python
`wheels <http://pythonwheels.com>`__ for every Python dependency our library
and tests have.

If new ``tox`` environments are added to be run in a Travis build, they
should either be:
should be listed in ``[tox].envlist`` as a default environment.

We speed up builds by using the Travis `caching feature`_.

- listed in ``[tox].envlist`` as a default environment
.. _caching feature: https://docs.travis-ci.com/user/caching/#pip-cache

- added to the list in the
`Travis environment variable <http://docs.travis-ci.com/user/environment-variables/#Using-Settings>`__
``EXTRA_TOX_ENVS``. This value is unencrypted in ``gcloud-python-wheels``
to make ongoing maintenance easier.
We intentionally **do not** cache the ``.tox/`` directory. Instead, we
allow the ``tox`` environments to be re-built for every build. This
way, we'll always get the latest versions of our dependencies and any
caching or wheel optimization to be done will be handled automatically
by ``pip``.

Supported Python Versions
-------------------------
Expand Down
21 changes: 0 additions & 21 deletions scripts/custom_pip_install.sh

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/merge.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ set -ev
##############################################
if [[ "${TRAVIS_BRANCH}" == "master" ]] && \
[[ "${TRAVIS_PULL_REQUEST}" == "false" ]]; then
echo "Building new docs on a merged commit."
scripts/update_docs.sh
scripts/update_wheels_project.sh
elif [[ -n "${TRAVIS_TAG}" ]]; then
echo "Building new docs on a tag."
scripts/update_docs.sh
Expand Down
61 changes: 0 additions & 61 deletions scripts/update_wheels_project.sh

This file was deleted.

2 changes: 0 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ envlist =
py26,py27,py33,py34,cover,docs,lint

[testenv]
install_command =
{toxinidir}/scripts/custom_pip_install.sh {opts} {packages}
commands =
nosetests
deps =
Expand Down