Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigquery: add table schemas #1022

Merged
merged 3 commits into from
Aug 4, 2015
Merged

Bigquery: add table schemas #1022

merged 3 commits into from
Aug 4, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 29, 2015

Based on #1021

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Jul 29, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2015
@tseaver tseaver mentioned this pull request Jul 29, 2015
Merged
@dhermes
Copy link
Contributor

dhermes commented Jul 29, 2015

Ping me when #1021 is in. We are pretty close to having that one in AFAICT.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 30, 2015

@dhermes rebased after merging #1021.

dhermes
dhermes reviewed Jul 30, 2015
View reviewed changes
gcloud/bigquery/table.py

:type field_type: string
:param field_type: the type of the field (one of 'STRING', 'INTEGER',
'FLOAT', 'BOOLEAN', 'TIMESTAMP' or 'RECORD')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Aug 4, 2015
Closed
dhermes
dhermes reviewed Aug 4, 2015
View reviewed changes
gcloud/bigquery/table.py
"""
if not all(isinstance(field, SchemaField) for field in value):
raise ValueError('Schema items must be fields')
self._schema = tuple(value)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Aug 4, 2015

LGTM.

I don't want the schema.setter to be a blocker, but do want to understand it.

tseaver added a commit that referenced this pull request Aug 4, 2015
@tseaver
Merge pull request #1022 from tseaver/bigquery-table_schema
ecf0004 
Bigquery: add table schemas
@tseaver tseaver merged commit ecf0004 into googleapis:master Aug 4, 2015
@tseaver tseaver deleted the bigquery-table_schema branch August 4, 2015 17:43
@dhermes dhermes mentioned this pull request Aug 12, 2015
Merged
atulep pushed a commit that referenced this pull request Apr 6, 2023
@dizcology @busunkim96
use region tags [(#1022)](GoogleCloudPlatform/python-docs-samples#1022)
fe0875a
atulep pushed a commit that referenced this pull request Apr 6, 2023
@dizcology @busunkim96
use region tags [(#1022)](GoogleCloudPlatform/python-docs-samples#1022)
2af615d
atulep pushed a commit that referenced this pull request Apr 18, 2023
@dizcology @busunkim96
use region tags [(#1022)](GoogleCloudPlatform/python-docs-samples#1022)
61029aa
parthea pushed a commit that referenced this pull request Oct 22, 2023
@dizcology @busunkim96
use region tags [(#1022)](GoogleCloudPlatform/python-docs-samples#1022)
4e2c0a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot