Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigquery table api methods #1023

Merged
merged 7 commits into from
Aug 5, 2015
Merged

Bigquery table api methods #1023

merged 7 commits into from
Aug 5, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 29, 2015

Uses #1022 as a base.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Jul 29, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Aug 4, 2015

Rebased after landing #1022

dhermes
dhermes reviewed Aug 4, 2015
View reviewed changes
gcloud/bigquery/dataset.py
:returns: a new ``Table`` instance

:type schema: list of :class:`gcloud.bigquery.table.SchemaField`
:param schema: The table's schema

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Aug 4, 2015
View reviewed changes
gcloud/bigquery/table.py
"""API call: update individual table properties via a PATCH request

See
https://cloud.google.com/bigquery/docs/reference/v2/tables/patch

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Aug 4, 2015
View reviewed changes
gcloud/bigquery/table.py
self._set_properties(api_response)

def patch(self, client=None, friendly_name=_MARKER, description=_MARKER,
location=_MARKER, expires=_MARKER, view_query=_MARKER):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Aug 5, 2015

Realized I need to update Table.patch() to support passing schema. The spec says schema is optional: I guess maybe it could be deleted to allow the back-end to infer it (e.g., from the view query?)

@dhermes
Copy link
Contributor

dhermes commented Aug 5, 2015

In another PR or here?

@tseaver
Copy link
Contributor Author

tseaver commented Aug 5, 2015

22bc7cd adds that support.

@dhermes
Copy link
Contributor

dhermes commented Aug 5, 2015

Cool. So the last thing to resolve is the KeyError question.

Also, how close are we to cutting a release with BigQuery stuff in it? My main reason for asking is so that we can make http://gcloud-python.readthedocs.org/en/stable/ actually look good.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 5, 2015

Also, how close are we to cutting a release with BigQuery stuff in it?

I expect to have a PR in today adding the synchronous table load / fetch stuff. The async stuff will take a bit longer (I don't have my head wrapped around all the jobs API yet).

@tseaver
Copy link
Contributor Author

tseaver commented Aug 5, 2015

@dhermes PTAL (post- 7210c8c ).

dhermes
dhermes reviewed Aug 5, 2015
View reviewed changes
gcloud/bigquery/dataset.py
if 'creationTime' in cleaned:
cleaned['creationTime'] = float(cleaned['creationTime'])
if 'lastModifiedTime' in cleaned:
cleaned['lastModifiedTime'] = float(cleaned['lastModifiedTime'])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Aug 5, 2015

LGTM

tseaver added a commit that referenced this pull request Aug 5, 2015
@tseaver
Merge pull request #1023 from tseaver/bigquery-table_api_methods
c7b436f 
Bigquery table api methods
@tseaver tseaver merged commit c7b436f into googleapis:master Aug 5, 2015
@tseaver tseaver deleted the bigquery-table_api_methods branch August 5, 2015 16:45
@dhermes dhermes mentioned this pull request Aug 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot