chore: migrate code from googleapis/proto3-json-serializer-nodejs#86
Merged
miguelvelezsa merged 86 commits intomainfrom Oct 10, 2025
Merged
chore: migrate code from googleapis/proto3-json-serializer-nodejs#86miguelvelezsa merged 86 commits intomainfrom
miguelvelezsa merged 86 commits intomainfrom
Conversation
* chore: repository setup * chore: update auto-approve.yml
Release-As: v0.1.0 * feat!: proto3 JSON serializer and deserializer * chore: add prelint step * chore: region tags * fix: script to run mocha * chore: no source-map-support/register needed
🤖 I have created a release \*beep\* \*boop\* --- ## 0.1.0 (2021-08-03) ### ⚠ BREAKING CHANGES * proto3 JSON serializer and deserializer (#2) ### Features * proto3 JSON serializer and deserializer ([#2](https://www.github.com/googleapis/proto3-json-serializer-nodejs/issues/2)) ([96255a7](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/96255a77c7714f33cae547db9160615d7f80a233)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [0.1.1](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.0...v0.1.1) (2021-08-04) ### Bug Fixes * accept and return strings for int64 and uint64 ([#7](https://www.github.com/googleapis/proto3-json-serializer-nodejs/issues/7)) ([35689ec](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/35689ecee55dbe6e4cf3327c535514d7fcb8332d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
## Description Ran into a couple issues with conflicting types / packages because protobufjs was not being imported locally. This meant it was using the global `protobuf` namespace before, when it was referencing [`protobuf.Message`](https://github.com/googleapis/proto3-json-serializer-nodejs/blob/main/typescript/src/toproto3json.ts#L44) in the function signature of `toProto3JSON`. ## Checklist Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/proto3-json-serializer-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
🤖 I have created a release \*beep\* \*boop\* --- ### [0.1.2](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.1...v0.1.2) (2021-08-17) ### Bug Fixes * use imported protobufjs in toproto3json.ts ([#9](https://www.github.com/googleapis/proto3-json-serializer-nodejs/issues/9)) ([f6c86c7](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/f6c86c777d567d8430b09dea3282e52af24d890f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
If `fromProto3JSON` sees an enum with an unknown value, do not fail. `fromObject` will then likely ignore the unknown value, resulting in an effectively unset enum field, which is still better than throwing an exception.
🤖 I have created a release \*beep\* \*boop\* --- ### [0.1.3](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.2...v0.1.3) (2021-08-18) ### Bug Fixes * do not fail for unknown enum values ([#11](https://www.github.com/googleapis/proto3-json-serializer-nodejs/issues/11)) ([ff9f0f1](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/ff9f0f1881b1aafacd693b4e24eaee9e56aff79c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [0.1.4](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.3...v0.1.4) (2021-09-20) ### Bug Fixes * do not emit empty lists to JSON ([#15](https://www.github.com/googleapis/proto3-json-serializer-nodejs/issues/15)) ([af9dfd6](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/af9dfd65efb84cfb31af0faca805f53b0ffa9874)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^14.11.2` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/proto3-json-serializer-nodejs).
🤖 I have created a release \*beep\* \*boop\* --- ### [0.1.5](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.4...v0.1.5) (2021-10-26) ### Bug Fixes * JSON accept special string for NaN, Infinity ([#19](https://www.github.com/googleapis/proto3-json-serializer-nodejs/issues/19)) ([01a345b](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/01a345b7b1d62ee65a8673737975980d274fa22a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [0.1.6](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.5...v0.1.6) (2021-11-15) ### Bug Fixes * **deps:** protobufjs is a dependency for the types ([#23](https://www.github.com/googleapis/proto3-json-serializer-nodejs/issues/23)) ([06470c1](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/06470c1df501439ec3f8bc546cd23d798604f3bd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
The fractional seconds in the JSON timestamps can go up to 9 digits (i.e. up to 1 nanosecond resolution). [timestamps.proto](https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/timestamp.proto#L115) However, Javascript Date object represent any date and time to millisecond precision. To keep the precision, we extract the fractional seconds and append 0 until the length is equal to 9.
🤖 I have created a release *beep* *boop* --- ### [0.1.7](googleapis/proto3-json-serializer-nodejs@v0.1.6...v0.1.7) (2022-01-14) ### Bug Fixes * keep nano second precision when maps between JSON and proto3 ([#28](googleapis/proto3-json-serializer-nodejs#28)) ([eaa01ce](googleapis/proto3-json-serializer-nodejs@eaa01ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
A timestamp might have no millisecond, form like `2022-01-01T00:00:00Z` vs `2022-01-01T00:00:00.000Z`.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* build: enable OwlBot * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
miguelvelezsa
force-pushed
the
proto3-json-serializer-nodejs-migration
branch
from
1a0e93d to
529f047
Compare
miguelvelezsa
changed the title
miguelvelezsa
force-pushed
the
proto3-json-serializer-nodejs-migration
branch
from
8aa2fae to
d3c3748
Compare
miguelvelezsa
force-pushed
the
proto3-json-serializer-nodejs-migration
branch
from
01534ea to
f4e9b4b
Compare
GautamSharda
approved these changes
Oct 10, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Oct 10, 2025
This was referenced Oct 22, 2025
GautamSharda
pushed a commit
that referenced
this pull request
Oct 29, 2025
](https://renovatebot.com){kind=link}
GautamSharda
pushed a commit
that referenced
this pull request
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json-bigint#81)GoogleAuth.getClient()viagax-nodejsvia@googlemaps/addressvalidationin AWS Lambda causes slow GCE metadata fetch attempt #80)system-test/fixturesto.eslintignore(chore: migrate code from googleapis/google-auth-library-nodejs #87)