migrate code from googleapis/gax-nodejs#134
Closed
miguelvelezsa wants to merge 1061 commits intomainfrom
Closed
Conversation
* fix(deps): update dependency protobufjs to v7 * fix: bump @grpc/proto-loader, use protobufjs-cli * fix: use protobufjs-cli * fix(deps): pin jsdoc to v3.6.7 Co-authored-by: Alexander Fenster <github@fenster.name>
* fix(deps): update dependency jsdoc to v3.6.10 * fix: do not depend on jsdoc Co-authored-by: Alexander Fenster <github@fenster.name>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* refactor: do not use typeof when comparing to undefined * fix: tests
* fix: make browser and rest use case work * test: refactor system and browser tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: pr feedback Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
We'll need to figure out the `Long` stuff once and forever. Pin the dependency for now.
…s (#1299) * fix: make sure we do not change casing for fields that are user inputs * add comments * address comments * make sure to keep changing requested fields as well * fix: do not recreate set each time * continue checking if requested fields exist * make sure set is not empty * remove logging * do not export function * chore: trigger CI Co-authored-by: Alexander Fenster <fenster@google.com>
* feat: add fallback logic in error handling * chore: fix typo * feat: restore error details removal Co-authored-by: Alexander Fenster <fenster@google.com>
…#1291) * fix: return Google Error when there is a missing required parameter * allow for undefined * fix: add import * add type * fix type * run lint * add transcoding test * add type * fix test * respond to comments * remove return GoogleError * assert transcode throws * add test * remove only * rerun tests * fix test * rejects promise * revert grpc-fallback changes * fix: simplify promises and callbacks * fix: lint Co-authored-by: Alexander Fenster <fenster@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore(deps): remove @types/download from devDependencies * chore(deps): add @types/download to showcase-server
Otherwise the generated `protos.d.ts` does not look good.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore: make browser test required * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: make owlbot happy Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/gax-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes https://github.com/googleapis/gax-nodejs/issues/1319 🦕
…1326) * fix: make fallback export more stuff * fix: add GoogleError * feat: export protobufMinimal separately * fix: formatting * fix: copyright year for the new file
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [protobufjs-cli](https://togithub.com/protobufjs/protobuf.js) | [`1.0.0` -> `1.0.1`](https://renovatebot.com/diffs/npm/protobufjs-cli/1.0.0/1.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protobufjs/protobuf.js</summary> ### [`v1.0.1`](https://togithub.com/protobufjs/protobuf.js/releases/tag/protobufjs-cli-v1.0.1) [Compare Source](https://togithub.com/protobufjs/protobuf.js/compare/protobufjs-cli-v1.0.0...protobufjs-cli-v1.0.1) ##### Bug Fixes - **deps:** update dependency glob to v8 ([#​1750](https://togithub.com/protobufjs/protobuf.js/issues/1750)) ([8303a64](https://togithub.com/protobufjs/protobuf.js/commit/8303a648bc12dcea5aa8e7efa042de39011857f9)) - remove unused `@types/long` ([#​1785](https://togithub.com/protobufjs/protobuf.js/issues/1785)) ([0f4af83](https://togithub.com/protobufjs/protobuf.js/commit/0f4af83e4ed3cef1ec035c2833e0b06cab0bd87f)) - **types:** update type deps ([#​1776](https://togithub.com/protobufjs/protobuf.js/issues/1776)) ([d87978b](https://togithub.com/protobufjs/protobuf.js/commit/d87978b8eb2a176676c58379a89206b94a6d926a)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gax-nodejs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE3Ni4wIn0=-->
* fix: refactor createByteLengthFunction, warn if fails * fix: formatting
* fix(deps): update dependency protobufjs to v7 * fix: bump @grpc/proto-loader, use protobufjs-cli * fix: use protobufjs-cli * fix(deps): pin jsdoc to v3.6.7 Co-authored-by: Alexander Fenster <github@fenster.name> Co-authored-by: Alexander Fenster <fenster@google.com>
🤖 I have created a release *beep* *boop* --- ## [3.3.1](googleapis/gax-nodejs@v3.3.0...v3.3.1) (2022-08-29) ### Bug Fixes * **deps:** update dependency protobufjs to v7.1.0 ([#1329](googleapis/gax-nodejs#1329)) ([fc5446e](googleapis/gax-nodejs@fc5446e)) * **deps:** update dependency protobufjs-cli to v1.0.1 ([#1328](googleapis/gax-nodejs#1328)) ([b810d37](googleapis/gax-nodejs@b810d37)) * refactor createByteLengthFunction, warn if fails ([#1331](googleapis/gax-nodejs#1331)) ([d27f7fa](googleapis/gax-nodejs@d27f7fa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
* chore: opt out from owlbot changes for CODEOWNERS * chore: add actools as a code owner * chore: undo change * chore: add actools as an owner * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* feat: in googleError in decodeHTTPError don't break if there is an unknown/custom in the errors details. * feat: in googleError:decoreHTTPError handle unknown/custom errors. * feat: support details with Any proto. * feat: when an error detail is not found, wrap it in an `Any` proto and include it in the final details returned. * feat: add function to get proto name from full name representation * feat: add function to decode Any proto in utils * feat: add function to decode Any protos from a list of protos in utils --------- Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
* feat: Use `GoogleAuth#fetch` and Fix Tests * chore: remove launch.json * style: lint * chore: remove unnecessary component * refactor: remove unneeded globals * remove unused import * refactor: base tsconfig.json * feat: open `baseDirectory` option (internal-only for now) * refactor: streamline options * fix: use correct reference * test: more test fixes * test: update browser tests * chore: spin-off async/void tests * refactor: pr suggestions * refactor: remove minification test * remove tests as talked about on chat, see #1770 for context --------- Co-authored-by: d-goog <188102366+d-goog@users.noreply.github.com> Co-authored-by: Leah Cole <coleleah@google.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
* feat: Use `GoogleAuth#fetch` and Fix Tests * chore: remove launch.json * style: lint * chore: remove unnecessary component * refactor: remove unneeded globals * remove unused import * refactor: base tsconfig.json * feat: open `baseDirectory` option (internal-only for now) * refactor: streamline options * fix: use correct reference * test: more test fixes * test: update browser tests * chore: spin-off async/void tests * refactor: pr suggestions * refactor: remove minification test * remove tests as talked about on chat, see #1770 for context * fix: re add minification tests Co-authored by: Daniel Bankhead <danielbankhead@google.com> --------- Co-authored-by: Daniel Bankhead <danielbankhead@google.com> Co-authored-by: d-goog <188102366+d-goog@users.noreply.github.com>
* WIP 204 * more on the 204 fallback logic * add test * reduce duplicated code, remove some unused imports * remove no longer needed clause
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore: fail faster in regapic unit tests * lint * chore: fail faster in pagedIteration unit tests * chore: fail faster in grpc-fallback unit tests * chore: fail faster in bundling unit tests * chore: fail faster in apiCallable unit tests * WIP - show sofia error :) * WIP for Sofia * revert changes to browser test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> Co-authored-by: miguel <miguelvelezsa@google.com>
Co-authored-by: miguel <miguelvelezsa@google.com>
* chore(main): release gapic-tools 1.0.3 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
* chore(main): release google-gax 5.0.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: add node 22 and 24 versions in ci tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: add retry in linkinator.config * fix: set concurrency to 1 in linkinator.config * Update .OwlBot.lock.yaml * chore: Update .OwlBot.lock.yaml --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
* chore(main): release google-gax 5.0.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* perf: remove abort controller polyfill All platforms support this now, so we don't need it anymore. Replaces #1788. * chore: run fix
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.