Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Mar 12, 2024

Fixes #13765

Same story as #13748. storage and bigtable do not call PopulateCommonOptions(), so we need to manually handle GOOGLE_CLOUD_CPP_OPENTELEMETRY_TRACING. They are the only two such libraries that need this manual works.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 12, 2024
@dbolduc dbolduc marked this pull request as ready for review March 12, 2024 22:14
@dbolduc dbolduc requested review from a team as code owners March 12, 2024 22:14
@codecov
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (95fce04) to head (9803b54).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13766   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files        2229     2229           
  Lines      193104   193121   +17     
=======================================
+ Hits       180105   180121   +16     
- Misses      12999    13000    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc merged commit abfe6e8 into googleapis:main Mar 13, 2024
@dbolduc dbolduc deleted the gcs-otel-tracing-env-var branch March 13, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants