Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Mar 8, 2024

Bigtable data plane does not use PopulateCommonOptions(...) so we copy the handling of GOOGLE_CLOUD_CPP_OPENTELEMETRY_TRACING:

e = GetEnv("GOOGLE_CLOUD_CPP_OPENTELEMETRY_TRACING");
if (e && !e->empty()) {
opts.set<OpenTelemetryTracingOption>(true);
}


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Mar 8, 2024
@codecov
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (95fce04) to head (84d028c).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13748      +/-   ##
==========================================
- Coverage   93.26%   93.26%   -0.01%     
==========================================
  Files        2229     2229              
  Lines      193104   193114      +10     
==========================================
+ Hits       180105   180112       +7     
- Misses      12999    13002       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review March 8, 2024 06:34
@dbolduc dbolduc requested a review from a team as a code owner March 8, 2024 06:34
@dbolduc dbolduc merged commit 31f6e5d into googleapis:main Mar 8, 2024
@dbolduc dbolduc deleted the bigtable-tracing-env-var branch March 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants