-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] GRPC routing metadata is incorrectly computed for update calls #364
Comments
The bug also happens with UpdateCryptoKeyVersion |
@software-dov , can you clarify if this issue happens in the micro-generator or is this something that we should fix in the current gapic? |
I think this bug only applies to the monolith generator. The issue is that monolith generator generated code takes individual fields, since one of the field can be either a dict or an object, but the code doesn't handle dict well, it throws exceptions. micro-generator doesn't allow users to provide fields separately, instead they have wrap the fields in a request object, so it won't have this issue. The following is an example demonstrating this. micro-generator generated echo method: monolith generator generated echo method: |
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This is now resolved for KMS (via migration to the microgenerator) |
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
As an example:
https://github.com/googleapis/google-cloud-python/blob/de73e45a7183a638113153d0faec105cfc437f0e/kms/google/cloud/kms_v1/gapic/key_management_service_client.py#L1569
When the
crypto_key
argument to UpdateCryptoKey is a dict, the attempt to resolvecrypto_key.name
results in an AttributeError ("'dict' object has no attribute 'name'"). The error is caught and ignored, so this fails silently.Reported by a customer at https://stackoverflow.com/questions/59617920/cant-update-cryptokey-in-us-central1
The text was updated successfully, but these errors were encountered: