Update and add Cloud KMS samples #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
CI failures seem to be quota related. |
tmatsuo
reviewed
May 5, 2020
sethvargo
force-pushed
the
sethvargo/kms_samples
branch
from
ea2e09f to
e010f96
Compare
kurtisvg
approved these changes
May 5, 2020
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
sethvargo
force-pushed
the
sethvargo/kms_samples
branch
from
3e9ae85 to
7368b90
Compare
tmatsuo
approved these changes
May 5, 2020
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Jun 4, 2020
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
busunkim96
pushed a commit
to busunkim96/python-kms
that referenced
this pull request
Jun 16, 2020
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
busunkim96
pushed a commit
to busunkim96/python-kms
that referenced
this pull request
Jun 16, 2020
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Jun 16, 2020
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…-docs-samples#3690) This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Cloud KMS samples to match the format from the other 6 languages. It also updates the samples to note the workaround for googleapis/gapic-generator-python#364.
I dropped all "runnable" samples except the quickstart. Only about half of the previous samples included them, and most were broken. I don't think KMS developers are running samples on the command line. Furthermore, KMS often deals in bytes (not strings), which requires developers to base64 encode/decode the data when using it on the CLI. This leads to confusion when developers try to use the API directly, since the API accepts raw bytes. The top questions on Python+KMS on Stackoverflow are entirely around this confusion.
There's also a bug in the new noxfile template, which I fixed in here.