This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Rename in/out properties to readable/writable #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the implementation in Blink and the example code in the Serial API explainer.
Contributor
jameshollyergoogle
left a comment
jameshollyergoogle
left a comment
There was a problem hiding this comment.
I named them in and out based on https://wicg.github.io/serial/#serialport-interface. Has this changed?
Contributor
Author
|
The specification text is out of date. The explainer and implementation in Chromium are the current reference for this API. The readable/writable naming matches other more modern specifications such as TransformStream. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the implementation in Blink and the example code in the Serial API explainer.