Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Commit 1e1b746

Browse files
Merge pull request #4 from reillyeon/stream_names
Rename in/out properties to readable/writable
2 parents 4011ce4 + c288a3b commit 1e1b746

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

demo.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ <h1>Serial API Polyfill Demo</h1>
4646
//probably want to do some checks here to make sure you get the correct device. We are just grabbing the first for the demo
4747
mySerial = serialDevices[0];
4848
await mySerial.open();
49-
reader = mySerial.in.getReader();
50-
writer = mySerial.out.getWriter();
49+
reader = mySerial.readable.getReader();
50+
writer = mySerial.writable.getWriter();
5151
}
5252
})
5353

@@ -60,8 +60,8 @@ <h1>Serial API Polyfill Demo</h1>
6060
serial.requestPort().then(async (serialPort) => {
6161
mySerial = serialPort;
6262
await mySerial.open();
63-
reader = mySerial.in.getReader();
64-
writer = mySerial.out.getWriter();
63+
reader = mySerial.readable.getReader();
64+
writer = mySerial.writable.getWriter();
6565
})
6666

6767

@@ -75,8 +75,8 @@ <h1>Serial API Polyfill Demo</h1>
7575
// mySerial = new serial.SerialPort(device);
7676
// await mySerial.open();
7777
//
78-
// reader = mySerial.in.getReader();
79-
// writer = mySerial.out.getWriter();
78+
// reader = mySerial.readable.getReader();
79+
// writer = mySerial.writable.getWriter();
8080
// }
8181
// );
8282
});

serial.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ const kStopbitsIndexMapping = [1, 1.5, 2];
5555

5656
/** a class used to control serial devices over WebUSB */
5757
export class SerialPort {
58-
public in: ReadableStream<Uint8Array>;
59-
public out: WritableStream<Uint8Array>;
58+
public readable: ReadableStream<Uint8Array>;
59+
public writable: WritableStream<Uint8Array>;
6060

6161
private transferInterface_: USBInterface;
6262
private serialOptions_: SerialOptions;
@@ -109,8 +109,8 @@ export class SerialPort {
109109
'value': 0x01,
110110
'index': controlInterface.interfaceNumber,
111111
});
112-
this.in = new ReadableStream({start: this.readStart.bind(this)});
113-
this.out = new WritableStream({
112+
this.readable = new ReadableStream({start: this.readStart.bind(this)});
113+
this.writable = new WritableStream({
114114
write: this.write.bind(this),
115115
});
116116
} catch (error) {

0 commit comments

Comments
 (0)