-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into dev/changelog #634
Conversation
The current implementation in protocol-usb matches the new documentation. The rationale for the change is to provide quick feedback to the host that the device is not ready to handle requests yet. This is not a big change because this part of the board API is not exposed to the applet API. It is exclusively used by the scheduler. We might want to do similar (and bigger) changes to other parts of the API (like UART or USB serial).
Part of #577 because the runner host without USB still needs to support the platform protocol.
Also improve the behavior on exit. In particular, fix the runner exiting properly when the web client is closed.
This is part of #577.
Part of #577. This is going to be used by `AppletExitStatus` too.
Co-authored-by: Zhou Fang <33002388+zhou-w-fang@users.noreply.github.com> Co-authored-by: Julien Cretin <cretin@google.com>
This will be useful for #577 which will introduce a file for the applet.
Also revert #618 since this is a better fix (`i686-unknown-linux-gnu` should only be used to compile a device, not a host, so it should not depend on `rusb`).
No need to compile one. We only use cargo check in testing (not cargo build), so we won't attempt to link the applet. The fact that we don't link is also important because the existing native applet could have been for another target triple.
This is needed for #278 since ideally want a single release of the host runner. And we still want this release to provide support for different transports. In particular because USB requires sudo and doesn't work in GitHub Codespaces.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
No description provided.