Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3LO loopback flow #132

Merged
merged 30 commits into from
Jun 28, 2022
Merged

Add support for 3LO loopback flow #132

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
77b4169
initial commit
ulisesL Jun 21, 2022
5c06a86
Added DisableAutoOpenConsentPage option. Removed ConsentPageAllowRedi…
ulisesL Jun 22, 2022
af6fde4
Modify getTimeDuration to handle incorrect units.
ulisesL Jun 22, 2022
5a36623
Improve comments for OverriddenURI.
ulisesL Jun 22, 2022
6f719ce
Introduce maxWaitForListenAndServe constant.
ulisesL Jun 22, 2022
4d833c0
Fix comment for consent page parameters.
ulisesL Jun 22, 2022
d9850f6
Remove Test3LOFlow fetch; 3lo; old interface --scope flag
ulisesL Jun 22, 2022
436cd0c
Improve '--credentials' description.
ulisesL Jun 22, 2022
5324b06
Move consent page options.
ulisesL Jun 22, 2022
e2035a8
Move consent page parameters.
ulisesL Jun 22, 2022
7636cb6
Rename localhost.go to loopback.go and add description.
ulisesL Jun 25, 2022
6b3169e
Add TODO to remove Test3LOFlow and rename tests in test3LOLoopbackFlow.
ulisesL Jun 25, 2022
7748c3e
Add --scope option in 'old interface' test in Test3LOLoopbackFlow.
ulisesL Jun 25, 2022
d3b8729
Fix usage of --disableAutoOpenConsentPage and documentation.
ulisesL Jun 25, 2022
ca8ff9f
Create clientIDFile util file.
ulisesL Jun 26, 2022
b7e21a0
Remove empty lines in cli_test.go and browser.go
ulisesL Jun 26, 2022
ba2e96e
Remove OverriddenURI logic.
ulisesL Jun 26, 2022
5359ff5
Fix regex expression in createKey in cache.go.
ulisesL Jun 26, 2022
affb2a1
Fix redirect_uris replacement in createKey in cache.go
ulisesL Jun 26, 2022
e1c9371
Move authorization handlers out of main. Remove extra empty lines.
ulisesL Jun 27, 2022
c0720d7
Rename clientIdFile.go.
ulisesL Jun 27, 2022
b9c9033
Fix typos.
ulisesL Jun 28, 2022
9359ce2
Improve comments in auth-handlers.go.
ulisesL Jun 28, 2022
2f44228
Reduce branching when handling 3LO loopback in main.
ulisesL Jun 28, 2022
90adb9f
Move consentPageSettings logic inside 3LO loopback case.
ulisesL Jun 28, 2022
0d26dec
Change scope of defer function in main. It should be inside the 3LO l…
ulisesL Jun 28, 2022
c4ea4be
Remove empty lines in loopback.go
ulisesL Jun 28, 2022
fd3c1ba
Print something saying could not auto open URL if OpenURL errors.
ulisesL Jun 28, 2022
2b43ee5
Replace ReplaceContentAll with strings.Replace.
ulisesL Jun 28, 2022
8ff4908
Fix TestServiceAccountImpersonationFlow.
ulisesL Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move consent page parameters.
  • Loading branch information
@ulisesL
ulisesL committed Jun 22, 2022
commit e2035a824f2cd56546a55d77bfbdd9d7721692c3
10 changes: 5 additions & 5 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,16 @@ type commonFetchOptions struct {
// Refresh is used for 3LO flow. When used in conjunction with caching, the user can avoid re-authorizing.
Refresh bool `long:"refresh" description:"If the cached access token is expired, attempt to refresh it using refreshToken."`

// Consent page parameters.
DisableAutoOpenConsentPage bool `long:"disableAutoOpenConsentPage" description:"Disables the ability to open the consent page automatically."`
ConsentPageInteractionTimeout int `long:"consentPageInteractionTimeout" description:"Maximum wait time for user to interact with consent page." default:"2"`
ConsentPageInteractionTimeoutUnits string `long:"consentPageInteractionTimeoutUnits" choice:"seconds" choice:"minutes" description:"Consent page timeout units." default:"minutes"`

// Deprecated flags kept for backwards compatibility. Hidden from help page.
Json string `long:"json" description:"Deprecated. Same as --credentials." hidden:"true"`
Jwt bool `long:"jwt" description:"Deprecated. Same as --type jwt." hidden:"true"`
Sso bool `long:"sso" description:"Deprecated. Same as --type sso." hidden:"true"`
OldFormat string `long:"credentials_format" choice:"bare" choice:"header" choice:"json" choice:"json_compact" choice:"pretty" description:"Deprecated. Same as --output_format" hidden:"true"`

// Consent page parameters.
DisableAutoOpenConsentPage bool `long:"disableAutoOpenConsentPage" description:"Disables the ability to open the consent page automatically."`
ConsentPageInteractionTimeout int `long:"consentPageInteractionTimeout" description:"Maximum wait time for user to interact with consent page." default:"2"`
ConsentPageInteractionTimeoutUnits string `long:"consentPageInteractionTimeoutUnits" choice:"seconds" choice:"minutes" description:"Consent page timeout units." default:"minutes"`
}

// Additional options for "fetch" command.
Expand Down