Conversation
…rect and ConsentPageCancelRedirect options. Updated README and tests cases accordingly.
andyrzhao
requested changes
Jun 22, 2022
andyrzhao
left a comment
andyrzhao
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR Ulises! This is a big change and I've left some comments regarding code organization - in general, lets move the new functions out of of main.go (into one or more util files as needed) to keep main.go as small as possible. (We can also think about adding co-located unit tests to some of the util functions in the future. Another reason to move it outside of main.go)
andyrzhao
requested changes
Jun 27, 2022
andyrzhao
left a comment
andyrzhao
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for addressing the previous comments! I've left some additional minor comments, should be good to merge the PR after that.
ulisesL
commented
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement logic to enable 3LO loopback.
util/loopback.go: contains the localhost-logic, which is in charge of handling the auth code and state.
util/browser.go: contains the logic to open the consent page in the OS default browser.
util/auth-handlers.go: makes use of loopback and browser to create the 3LO loopback algorithm.