Skip to content

Make ui/server/registrar and flows targets public #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2016
Merged

Make ui/server/registrar and flows targets public #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ Pablo Mayrgundter <pmy@google.com>
Daisuke Yabuki <dxy@google.com>
Tim Boring <tjb@google.com>
Hans Ridder <hans.ridder@gmail.com>
Wolfgang Meyers <wolfgang@donuts.co>
1 change: 1 addition & 0 deletions java/com/google/domain/registry/flows/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,5 @@ java_library(
"//third_party/java/objectify:objectify-v4_1",
"//third_party/java/servlet/servlet_api",
],
visibility = ["//visibility:public"],
)
1 change: 1 addition & 0 deletions java/com/google/domain/registry/ui/server/registrar/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ java_library(

"//third_party/closure/templates",
],
visibility = ["//visibility:public"],
Copy link
Contributor

@jart jart Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity why do you need to make the ui/server/registrar package visible? The description only mentions making flows visible.

Copy link
Contributor Author

@wolfgangmeyers wolfgangmeyers Apr 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flows was the first package I encountered that needed visibility changes. Note that the latest commit message mentions flows and registrar packages. I need access to these packages to reuse the login checks (SessionUtils). If you'd prefer to keep these private, I can recreate the logic.

)