Skip to content

Conversation

@wolfgangmeyers
Copy link
Contributor

This change is necessary in order to directly use the Epp flows
from another project.

@wolfgangmeyers
Copy link
Contributor Author

reviewer = @jart

@jart
Copy link
Contributor

jart commented Apr 4, 2016

Can you whitelist the specific targets you need, rather than whitelisting the entire packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was out of scope. I can change it back if you'd like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this whitespace change.

@wolfgangmeyers
Copy link
Contributor Author

Done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity why do you need to make the ui/server/registrar package visible? The description only mentions making flows visible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flows was the first package I encountered that needed visibility changes. Note that the latest commit message mentions flows and registrar packages. I need access to these packages to reuse the login checks (SessionUtils). If you'd prefer to keep these private, I can recreate the logic.

@wolfgangmeyers wolfgangmeyers changed the title Made flows package publicly visible Made ui/server/registrar and flows targets publicly visible Apr 11, 2016
@wolfgangmeyers wolfgangmeyers changed the title Made ui/server/registrar and flows targets publicly visible Make ui/server/registrar and flows targets publicly visible Apr 11, 2016
@wolfgangmeyers wolfgangmeyers changed the title Make ui/server/registrar and flows targets publicly visible Make ui/server/registrar and flows targets public Apr 11, 2016
@jart
Copy link
Contributor

jart commented Apr 11, 2016

Please squash to one commit.

Needed to reuse server-side XSRF protection
@wolfgangmeyers
Copy link
Contributor Author

done

@jart jart merged commit 3fb9649 into google:master Apr 11, 2016
@wolfgangmeyers wolfgangmeyers deleted the flows-visibility branch June 7, 2016 16:15
weiminyu pushed a commit to weiminyu/nomulus that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants