-
Notifications
You must be signed in to change notification settings - Fork 292
Make ui/server/registrar and flows targets public #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
reviewer = @jart |
|
Can you whitelist the specific targets you need, rather than whitelisting the entire packages? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this was out of scope. I can change it back if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this whitespace change.
|
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity why do you need to make the ui/server/registrar package visible? The description only mentions making flows visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flows was the first package I encountered that needed visibility changes. Note that the latest commit message mentions flows and registrar packages. I need access to these packages to reuse the login checks (SessionUtils). If you'd prefer to keep these private, I can recreate the logic.
|
Please squash to one commit. |
Needed to reuse server-side XSRF protection
|
done |
Sync from upstream google/nomulus parent
This change is necessary in order to directly use the Epp flows
from another project.