Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix uint64 #362

Closed
wants to merge 1 commit into from
Closed

fix uint64 #362

wants to merge 1 commit into from

Conversation

mrmiywj
Copy link

@mrmiywj mrmiywj commented Apr 2, 2016

fix #361

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mrmiywj
Copy link
Author

mrmiywj commented Apr 2, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@cmumford
Copy link
Contributor

Addressed in pull request nw362#354

@cmumford cmumford closed this Apr 12, 2016
maochongxin pushed a commit to maochongxin/leveldb that referenced this pull request Jul 21, 2022
@biojppm @dominichamon
Fixes google#357: broken RMS values when time unit is set. (google#362)
9a5072d
maochongxin pushed a commit to maochongxin/leveldb that referenced this pull request Jul 21, 2022
@biojppm
Unit testing: add facilities to check benchmark results.
6452883 
This is needed for examining the values of user counters (needed
for google#348). It is also needed for checking the values of standard
benchmark results like items_processed or complexities (for example,
checking the standard deviation is needed for unit testing google#357
as discussed in google#362).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uint64_t is not a member of "std"
3 participants
@mrmiywj @googlebot @cmumford