Fix signed/unsigned mismatch on VC++ builds #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not a google employee and I don't need to be approved to submit PRs to this repo ;) |
cmumford
added a commit
that referenced
this pull request
Feb 24, 2016
Fix signed/unsigned mismatch on VC++ builds
maochongxin
pushed a commit
to maochongxin/leveldb
that referenced
this pull request
Jul 21, 2022
This is needed for examining the values of user counters (needed for google#348). It is also needed for checking the values of standard benchmark results like items_processed or complexities (for example, checking the standard deviation is needed for unit testing google#357 as discussed in google#362).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a signed/unsigned mismatch on Windows/VC++ builds with VC++ 2013 and 2015. It happens when we do a 64-bit build of leveldb_skiplist_test, with this command:
The warning is:
I am a Google employee and therefore approved for submitting PRs to this repo.