Handle the intersection of convert function, !nullable & !includeIfNull #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a field has a conversion function defined – either `JsonKey.toJson` or a custom `JsonConverter` annotation – handle the case where the function returns `null` and both `nullable` and `includeIfNull` are `false`. Before this change, you could still get `null` values in output JSON even if `includeIfNull` is `false`. Prepare to release v2.2.0
|
@jakemac53 – FYI, I'm going to ditch wrapper support. Too darn complicated! #441 |
natebosch
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a field has a conversion function defined – either
JsonKey.toJsonor a custom
JsonConverterannotation – handle the case where thefunction returns
nulland bothnullableandincludeIfNullarefalse.Before this change, you could still get
nullvalues in output JSONeven if
includeIfNullisfalse.Prepare to release v2.2.0