Add extra check in GenericOp::verify #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing context-aware dialect conversion, sometimes the GenericOp's body can be detached from the op while the conversion is ongoing. When that happens, if the framework tries to verify the generic op, say, when attempting to dump the IR, this verification hook will fail because the region is empty and has no blocks. This extra check allows the verification to fail gracefully.
ZenithalHourlyRate
approved these changes
Mar 19, 2025
j2kun
added
the
pull_ready
asraa
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1552
When doing context-aware dialect conversion, sometimes the GenericOp's body can be detached from the op while the conversion is ongoing. When that happens, if the framework tries to verify the generic op, say, when attempting to dump the IR, this verification hook will fail because the region is empty and has no blocks. This extra check allows the verification to fail gracefully.