Halevi-Shoup matvec kernel #1552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2kun
force-pushed
the
linalg-kernels
branch
2 times, most recently
from
97d03da to
6cce260
Compare
This was referenced Mar 18, 2025
j2kun
added a commit
to j2kun/heir
that referenced
this pull request
Mar 19, 2025
Add gitattributes for bazel-provided merge conflict resolution in the lockfile. Added a patch to re2 (transitive dep via or-tools) due to google/re2#525 Extracted from google#1552
Merged
j2kun
force-pushed
the
linalg-kernels
branch
2 times, most recently
from
14643ef to
4a5006b
Compare
This commit also introduces tensor_ext.alignment which tracks data replication during packing.
asraa
reviewed
Mar 19, 2025
Comment on lines
87
to
88
| values to pad at the end of that axis. The `paddingValue` attribute, | ||
| defaulting to zero, describes the value used for padding. |
There was a problem hiding this comment.
Update here if you go the route of a possible unspecified padding - The paddingValue attr describes the value used for padding. If left unspecified, then the program will allow any value to be present in the padded slots.
Comment on lines
+38
to
+42
| DenseSet<long> insertedDimsSet(insertedDims.asArrayRef().begin(), | ||
| insertedDims.asArrayRef().end()); | ||
| if (insertedDimsSet.size() != insertedDims.size()) { | ||
| return emitError() << "insertedDims must all be unique"; | ||
| } |
There was a problem hiding this comment.
for the sake of verification, these probably should be within bounds as well? The code below that sets beforeReplication doesn't mind if they're out of range.
asraa
reviewed
Mar 19, 2025
lib/Transforms/ConvertToCiphertextSemantics/ConvertToCiphertextSemantics.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased over #1428