MOE Sync 2020-07-22 #3971
Merged
MOE Sync 2020-07-22 #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3908 Fixes #1315 Somewhat relevant to #3655 Vaguely relevant to google/error-prone#1490, since it creates a `@CheckReturnValue` variant of a `java.util.concurrent` method that returns `false` to indicate timeout. RELNOTES=`util.concurrent`: Added `awaitTerminationUninterruptibly`. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=322581454
cpovirk
added
the
internal-sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Add awaitTerminationUninterruptibly.
Fixes #3908
Fixes #1315
Somewhat relevant to #3655
Vaguely relevant to google/error-prone#1490, since it creates a
@CheckReturnValuevariant of ajava.util.concurrentmethod that returnsfalseto indicate timeout.RELNOTES=
util.concurrent: AddedawaitTerminationUninterruptibly.1ec90b0