-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1315 Add awaitTerminationUninterruptibly(..) for ExecutorService - M… #3908
Conversation
…ce - Methods and Testcases
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it!
…On Thu, May 21, 2020 at 7:09 PM googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle%2Fguava%2Fpull%2F3908>
for more info*.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3908 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADNQ3YFEPL6LADZDHLJJYY3RSWYA3ANCNFSM4NHIUQYQ>
.
|
@googlebot I signed it! |
@googlebot I signed it!
…On Thu, May 21, 2020 at 7:14 PM Nisarg Chokshi ***@***.***> wrote:
@googlebot I signed it!
On Thu, May 21, 2020 at 7:09 PM googlebot ***@***.***>
wrote:
> Thanks for your pull request. It looks like this may be your first
> contribution to a Google open source project (if not, look below for help).
> Before we can look at your pull request, you'll need to sign a Contributor
> License Agreement (CLA).
>
> 📝 *Please visit https://cla.developers.google.com/
> <https://cla.developers.google.com/> to sign.*
>
> Once you've signed (or fixed any issues), please reply here with @googlebot
> I signed it! and we'll verify it.
> ------------------------------
> What to do if you already signed the CLA Individual signers
>
> - It's possible we don't have your GitHub username or you're using a
> different email address on your commit. Check your existing CLA data
> <https://cla.developers.google.com/clas> and verify that your email
> is set on your git commits
> <https://help.github.com/articles/setting-your-email-in-git/>.
>
> Corporate signers
>
> - Your company has a Point of Contact who decides which employees are
> authorized to participate. Ask your POC to be added to the group of
> authorized contributors. If you don't know who your Point of Contact is,
> direct the Google project maintainer to go/cla#troubleshoot (Public
> version <https://opensource.google/docs/cla/#troubleshoot>).
> - The email used to register you as an authorized contributor must be
> the email used for the Git commit. Check your existing CLA data
> <https://cla.developers.google.com/clas> and verify that your email
> is set on your git commits
> <https://help.github.com/articles/setting-your-email-in-git/>.
> - The email used to register you as an authorized contributor must
> also be attached to your GitHub account
> <https://github.com/settings/emails>.
>
> ℹ️ *Googlers: Go here
> <https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle%2Fguava%2Fpull%2F3908>
> for more info*.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#3908 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADNQ3YFEPL6LADZDHLJJYY3RSWYA3ANCNFSM4NHIUQYQ>
> .
>
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Fixes #3908 Fixes #1315 Somewhat relevant to #3655 Vaguely relevant to google/error-prone#1490, since it creates a `@CheckReturnValue` variant of a `java.util.concurrent` method that returns `false` to indicate timeout. RELNOTES=`util.concurrent`: Added `awaitTerminationUninterruptibly`. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=322581454
Fixes #3908 Fixes #1315 Somewhat relevant to #3655 Vaguely relevant to google/error-prone#1490, since it creates a `@CheckReturnValue` variant of a `java.util.concurrent` method that returns `false` to indicate timeout. RELNOTES=`util.concurrent`: Added `awaitTerminationUninterruptibly`. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=322581454
@cpovirk
Kindly review the changes and suggest edits.
Thanks,
Nisarg