Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1315 Add awaitTerminationUninterruptibly(..) for ExecutorService - M… #3908

Closed
wants to merge 1 commit into from

Conversation

NisargC
Copy link

@NisargC NisargC commented May 21, 2020

@cpovirk
Kindly review the changes and suggest edits.

Thanks,
Nisarg

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@NisargC
Copy link
Author

NisargC commented May 21, 2020 via email

@NisargC
Copy link
Author

NisargC commented May 22, 2020

@googlebot I signed it!

@NisargC
Copy link
Author

NisargC commented May 23, 2020 via email

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@cpovirk cpovirk self-assigned this Jun 10, 2020
@cpovirk cpovirk mentioned this pull request Jul 22, 2020
cpovirk added a commit that referenced this pull request Jul 22, 2020
Fixes #3908
Fixes #1315
Somewhat relevant to #3655
Vaguely relevant to google/error-prone#1490, since it creates a `@CheckReturnValue` variant of a `java.util.concurrent` method that returns `false` to indicate timeout.

RELNOTES=`util.concurrent`: Added `awaitTerminationUninterruptibly`.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=322581454
cpovirk added a commit that referenced this pull request Jul 22, 2020
Fixes #3908
Fixes #1315
Somewhat relevant to #3655
Vaguely relevant to google/error-prone#1490, since it creates a `@CheckReturnValue` variant of a `java.util.concurrent` method that returns `false` to indicate timeout.

RELNOTES=`util.concurrent`: Added `awaitTerminationUninterruptibly`.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=322581454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants