Skip to content

Add missing max_sequences_per_bin for packed inputs #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yeandy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing max_sequences_per_bin for packed inputs #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion grain/_src/python/experimental/example_packing/packing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,10 @@ def __call__(
if not element_added_to_batch:
yield self._cur_batch.get_packed_batch() # Main yield
self._cur_batch = _PackedBatch(
element.data, self.batch_size, self.length_struct
element.data,
self.batch_size,
self.length_struct,
self.max_sequences_per_bin,
)
self._cur_batch.try_add_to_batch(element)

Expand Down