Add missing max_sequences_per_bin for packed inputs#1215
Open
yeandy wants to merge 1 commit intogoogle:mainfrom
Open
Add missing max_sequences_per_bin for packed inputs#1215yeandy wants to merge 1 commit intogoogle:mainfrom
yeandy wants to merge 1 commit intogoogle:mainfrom
Conversation
Author
|
@iindyk Can you please review? Thanks! |
Collaborator
|
thanks, can you please share your email associated with GH account in some way? I can attribute you the exported change that way (we have to submit all changes internally) |
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
ported from #1215 PiperOrigin-RevId: 866620681
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix a small bug from the original PR #1039. The original issue (#1000) was to meant to allow the user to specify the maximum segments packet into a sequence.
However, the addition only added the
self.max_sequences_per_binargument to the first instance of_PackedBatch, but not the second instance. See code section https://github.com/google/grain/blob/v0.2.15/grain/_src/python/experimental/example_packing/packing.py#L219-L236. This PR adds the missingself.max_sequences_per_bin.📚 Documentation preview 📚: https://google-grain--1215.org.readthedocs.build/